[cdt-patch] CommandLauncher workaround for IBM j9

["Alain Magloire" <alain@xxxxxxx>]

2002-12-10 Alain Magloire

        There is a bug in IMB j9 VM in the PipedInputStream class, when the
        buffer is full it is returning 0 instead of buffer.length.  We
        go around by overloading the available() method.  This should
        be remove once the bug is fix.

        * src/org.eclipse.cdt.core/CCommandLauncher.java (waitAndRead):
        overload available() method in the input stream.
        Set the error message correctly when the command is canceled.


Index: CommandLauncher.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core/src/org/eclipse/cdt/core/CommandLauncher.java,v
retrieving revision 1.3
diff -u -r1.3 CommandLauncher.java
--- CommandLauncher.java	24 Nov 2002 15:59:12 -0000	1.3
+++ CommandLauncher.java	10 Dec 2002 14:34:29 -0000
@@ -28,7 +28,7 @@
 	protected boolean fShowCommand;
 	protected String[] fCommandArgs;
 	
-	protected String fErrorMessage;
+	protected String fErrorMessage = "";
 	
 	private String lineSeparator;
 	
@@ -59,7 +59,11 @@
 	public String getErrorMessage() {
 		return fErrorMessage;
 	}
-	
+
+	public void setErrorMessage(String error) {
+		fErrorMessage = error;
+	}
+
 	public String[] getCommandArgs() {
 		return fCommandArgs;
 	}	
@@ -88,7 +92,7 @@
 			fProcess= ProcessFactory.getFactory().exec(fCommandArgs, env, changeToDirectory.toFile());
 			fErrorMessage= "";
 		} catch (IOException e) {
-			fErrorMessage= e.getMessage();
+			setErrorMessage(e.getMessage());
 			fProcess= null;
 		}
 		return fProcess;
@@ -117,9 +121,9 @@
 	 * Destroys the process if the monitor becomes canceled
 	 * override to implement a different way to read the process inputs
 	 */
-	public int waitAndRead(OutputStream out, OutputStream err, IProgressMonitor monitor) {
+	public int waitAndRead(OutputStream output, OutputStream err, IProgressMonitor monitor) {
 		if (fShowCommand) {
-			printCommandLine(fCommandArgs, out);
+			printCommandLine(fCommandArgs, output);
 		}	
 
 		if (fProcess == null) {
@@ -130,9 +134,42 @@
 		PipedOutputStream outputPipe = new PipedOutputStream();
 		PipedInputStream errInPipe, inputPipe;
 		try {
-			errInPipe = new PipedInputStream(errOutPipe);
-			inputPipe = new PipedInputStream(outputPipe);
+			errInPipe = new PipedInputStream(errOutPipe) {
+				/**
+				 * FIXME: To remove when j9 is fix.
+				 * The overloading here corrects a bug in J9
+				 * When the ring buffer when full it returns 0 .
+				 */
+				public synchronized int available() throws IOException {
+					if(in < 0)
+						return 0;
+					else if(in == out)
+						return buffer.length;
+					else if (in > out)
+						return in - out;
+					else
+						return in + buffer.length - out;
+				}
+			};
+			inputPipe = new PipedInputStream(outputPipe) {
+				/**
+				 * FIXME: To remove when j9 is fix.
+				 * The overloading here corrects a bug in J9
+				 * When the ring buffer when full returns 0.
+				 */
+				public synchronized int available() throws IOException {
+					if(in < 0)
+						return 0;
+					else if(in == out)
+						return buffer.length;
+					else if (in > out)
+						return in - out;
+					else
+						return in + buffer.length - out;
+				}
+			};
 		} catch( IOException e ) {
+			setErrorMessage("Command canceled");
 			return COMMAND_CANCELED;
 		}
 						
@@ -149,8 +186,8 @@
 				}
 				if ( inputPipe.available() > 0 ) {
 					nbytes = inputPipe.read(buffer);
-					out.write(buffer, 0, nbytes);
-					out.flush();
+					output.write(buffer, 0, nbytes);
+					output.flush();
 				}
 			} catch( IOException e) {
 			}
@@ -167,6 +204,7 @@
 		if (monitor.isCanceled()) {
 			closure.terminate();
 			state = COMMAND_CANCELED;
+			setErrorMessage("Command canceled");
 		}
 
 		try {
@@ -186,8 +224,8 @@
 				}
 				if ( inputPipe.available() > 0 ) {
 					nbytes = inputPipe.read(buffer);
-					out.write(buffer, 0, nbytes);
-					out.flush();
+					output.write(buffer, 0, nbytes);
+					output.flush();
 				}
 			}
 			errInPipe.close();