[cdt-patch] CBuilder fixes.

["Alain Magloire" <alain@xxxxxxx>]

Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core/ChangeLog,v
retrieving revision 1.39
diff -u -r1.39 ChangeLog
--- ChangeLog	22 Nov 2002 16:33:21 -0000	1.39
+++ ChangeLog	22 Nov 2002 17:01:55 -0000
@@ -1,5 +1,21 @@
 2002-11-22 Alain Magloire
 
+	The C Builder on error would clear the build.
+	The side effect of that is on every BuildAll
+	or Rebuild on the workspace, it will try to
+	rebuild the projects since it has not states.
+	It seems to work fine for JDT, where the builder
+	has full control and can quickly make a decision
+	The situation is not the same for the CDT, where we
+	spawn an external tool (make) even if nothing changes
+	i.e. the Makefiles rules when properly done will see,
+	it still seems sloppy.  So we remove this behaviour.
+
+	* src/.../internal/core/CBuilder.java (invokeMake):
+	Not to clear the state when errors.
+
+2002-11-22 Alain Magloire
+
 	* src/.../cdt/core/model/IBinary.java (isCore):
 	New method.
 	* src/.../cdt/core/model/IBinaryParser.java (CORE):
Index: src/org/eclipse/cdt/internal/core/CBuilder.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/core/CBuilder.java,v
retrieving revision 1.13
diff -u -r1.13 CBuilder.java
--- src/org/eclipse/cdt/internal/core/CBuilder.java	22 Nov 2002 14:53:48 -0000	1.13
+++ src/org/eclipse/cdt/internal/core/CBuilder.java	22 Nov 2002 17:01:55 -0000
@@ -91,7 +91,6 @@
 
 	private boolean invokeMake(boolean fullBuild, IProgressMonitor monitor) {
 		boolean isClean = false;
-		boolean fatalBuild = false;
 		boolean isCanceled = false;
 		IProject currProject = getProject();
 		SubProgressMonitor subMonitor = null;
@@ -161,7 +160,7 @@
 				subMonitor = new SubProgressMonitor(monitor, IProgressMonitor.UNKNOWN);
 				subMonitor.subTask("Parsing");
 
-				fatalBuild = epm.reportProblems();
+				epm.reportProblems();
 
 				if (errMsg != null) {
 					String errorDesc = CCorePlugin.getFormattedString(BUILD_ERROR, makepath.toString());
@@ -170,7 +169,6 @@
 					buf.append("(").append(errMsg).append(")");
 					cos.write(buf.toString().getBytes());
 					cos.flush();
-					fatalBuild = true;
 				}
 				subMonitor.done();
 				monitor.setCanceled(isCanceled);
@@ -181,7 +179,7 @@
 			CCorePlugin.log(e);
 		}
 		monitor.done();
-		return (isClean || fatalBuild);
+		return (isClean);
 	}
 
 	/**