Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-patch] Removed the ReferenceBlock from the Project Properties display

> 
> 

Bonjour

I'm not sure I follow the rationale of this patch.

We do basically the same thing as JDT(Propeties -> "Java Build Path")
where you have Reference Project filter on nature(Java Nature).

Those projects(when selected) are required for a build.

> 
> ***
> cvs diff -N -u "ChangeLog"
>   Index: ChangeLog
>   =
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>   RCS file: /home/tools/org.eclipse.cdt.ui/ChangeLog,v
>   retrieving revision 1.12
>   diff -u -r1.12 ChangeLog
>   --- ChangeLog	29 Oct 2002 21:40:58 -0000	1.12
>   +++ ChangeLog	31 Oct 2002 20:38:45 -0000
>   @@ -1,3 +1,19 @@
>   +2002-10-31 Judy N. Green
>   +	Removed the ReferenceBlock from the Project Properties display.
> Eclipse
>   +	adds a Project Properties entry to the Project Properties.
>   +	This was resulting in confusion since the=20
>   +	C/C++ Project --> Project References (filtered on nature =3D=3D =
> cnature)
>   +=09
>   +	and the=20
>   +	Project References (unfiltered, showing all projects)
>   +=09
>   +	Both listed some files in common, but they were not linked in any
> way
>   +	so the user could get into a very awkward state, when selecting or
> deselecting
>   +	as one view woud over ride the other.
>   +=09
>   +
> src/org/eclipse/cdt/internal/ui/preferences/CProjectPropertyPage.java
>   +=09
>   +=09
>    2002-10-29 David Inglis
>   =20
>    	Refactor ui.internal.CPlugin to ui.CUIPlugin with method to get the
> new=20
> 
> 
> 
> 
> ***
> cvs diff -N -u "CProjectPropertyPage.java"
>   Index: CProjectPropertyPage.java
>   =
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>   RCS file:
> /home/tools/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/preferenc=
> es/C
> ProjectPropertyPage.java,v
>   retrieving revision 1.5
>   diff -u -r1.5 CProjectPropertyPage.java
>   --- CProjectPropertyPage.java	29 Oct 2002 21:40:58 -0000	1.5
>   +++ CProjectPropertyPage.java	31 Oct 2002 20:32:35 -0000
>   @@ -9,7 +9,6 @@
>    import org.eclipse.cdt.internal.ui.dialogs.IStatusChangeListener;
>    import org.eclipse.cdt.internal.ui.dialogs.StatusTool;
>    import org.eclipse.cdt.ui.CUIPlugin;
>   -import org.eclipse.cdt.ui.wizards.ReferenceBlock;
>    import org.eclipse.cdt.ui.wizards.SettingsBlock;
>    import org.eclipse.cdt.utils.ui.controls.TabFolderLayout;
>    import org.eclipse.cdt.utils.ui.swt.IValidation;
>   @@ -32,7 +31,6 @@
>    	private static final String MSG_CLOSEDPROJECT=3D
> "CProjectPropertyPage.closedproject";
>    =09
>    	private TabFolder folder;
>   -	ReferenceBlock referenceBlock;
>    	SettingsBlock settingsBlock;
>   =20
>    	protected Control createContents(Composite parent) {
>   @@ -53,15 +51,6 @@
>    		folder =3D new TabFolder(parent, SWT.NONE);
>    		folder.setLayout(new TabFolderLayout());
>   =20
>   -		referenceBlock =3D new ReferenceBlock(this, getProject());
>   -		TabItem item =3D new TabItem(folder, SWT.NONE);
>   -		item.setText(referenceBlock.getLabel());
>   -		Image img =3D referenceBlock.getImage();
>   -		if (img !=3D null)
>   -			item.setImage(img);
>   -		item.setData(referenceBlock);
>   -		item.setControl(referenceBlock.getControl(folder));
>   -
>    		settingsBlock =3D new SettingsBlock(this, getProject());
>    		TabItem item2 =3D new TabItem(folder, SWT.NONE);
>    		item2.setText(settingsBlock.getLabel());
>   @@ -84,9 +73,7 @@
>   =20
>    	public void setComplete(boolean complete) {
>    		boolean ok =3D true;
>   -		if (referenceBlock !=3D null) {
>   -			ok =3D referenceBlock.isValid();
>   -		}
>   +	=09
>    		if (ok && settingsBlock !=3D null) {
>    			ok =3D settingsBlock.isValid();
>    		}
>   @@ -99,8 +86,7 @@
>    	public boolean performOk() {
>    		if (settingsBlock !=3D null)
>    			settingsBlock.doRun(getProject(), null);
>   -		if (referenceBlock !=3D null)
>   -			referenceBlock.doRun(getProject(), null);
>   +	=09
>    		return true;
>    	}
>    	=09
>   @@ -119,7 +105,6 @@
>    		super.setVisible(visible);
>    		if (visible && folder !=3D null) {
>    			settingsBlock.setVisible(visible);
>   -			referenceBlock.setVisible(visible);
>    			folder.setFocus();
>    		}
>    	}=09
> 
> 
> =A8=A8=A8=B0=BAo=A7o=BA=B0=A8=A8=A8=A8=B0=BAo=A7o=BA=B0=A8=A8=A8=A8=B0=BA=
> o=A7o=BA=B0=A8=A8=A8=A8=B0=BAo=A7o=BA=B0=A8=A8=A8
> Judy N. Green               Software Engineer
> QNX Software Systems Ltd.   www.qnx.com
> =A8=A8=A8=B0=BAo=A7o=BA=B0=A8=A8=A8=A8=B0=BAo=A7o=BA=B0=A8=A8=A8=A8=B0=BA=
> o=A7o=BA=B0=A8=A8=A8=A8=B0=BAo=A7o=BA=B0=A8=A8=A8
> _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-patch
> 


-- 
au revoir, alain
----
Aussi haut que l'on soit assis, on est toujours assis que sur son cul !!!



Back to the top