Re: [cdt-patch] JUnit test fixes.

[Peter Graves <pgraves@xxxxxxx>]

I have applied a slightly modified patch.  I removed the entire test 
point related to this test and cleaned up unused imports/variables. Also 
added a Changelog
Index: Changelog
===================================================================
RCS file: Changelog
diff -N Changelog
--- /dev/null    1 Jan 1970 00:00:00 -0000
+++ Changelog    30 Oct 2002 20:52:11 -0000
@@ -0,0 +1,4 @@
+2002-10-30 Alain Magloire
+
+    * core/org/eclipse/cdt/debug/core/tests/TargetTests.java: Test number
+    24183 is no longer valid, the method was remove from the CDI API.
\ No newline at end of file

Index: core/org/eclipse/cdt/debug/core/tests/TargetTests.java
===================================================================
RCS file: 
/home/tools/org.eclipse.cdt.debug.ui.tests/core/org/eclipse/cdt/debug/core/tests/TargetTests.java,v
retrieving revision 1.1
diff -u -r1.1 TargetTests.java
--- core/org/eclipse/cdt/debug/core/tests/TargetTests.java    10 Oct 
2002 18:22:09 -0000    1.1
+++ core/org/eclipse/cdt/debug/core/tests/TargetTests.java    30 Oct 
2002 20:52:12 -0000
@@ -17,7 +17,6 @@
import org.eclipse.core.runtime.*;
import org.eclipse.cdt.debug.mi.core.*;
import org.eclipse.cdt.debug.core.cdi.*;
-import org.eclipse.cdt.debug.core.cdi.model.*;

/**
 * @author Peter Graves
@@ -92,52 +91,19 @@


    /***
-     * A couple tests to make sure setting breakpoints on functions 
works as
-     * expected.
+     * A couple tests to make sure various evaluations work as expected
     */
    public void testEvaluate() throws CoreException, MIException, 
IOException, CDIException, InterruptedException {
        ICDISession session;
        ICDIBreakpointManager breaks;
-        ICDILocation location;
-        ICDITarget targets[];
        session=CDebugHelper.createSession("main");
        assertNotNull(session);
        breaks=session.getBreakpointManager();
        assertNotNull(breaks);
   
-       
-        
/**********************************************************************
-         * Test to make sure if we call 
ICDITarget.evaluateExpressionToValue
-         * seems to work.
-         
**********************************************************************/   
-  
-        location=breaks.createLocation(null, "func1", 0);
-        assertNotNull(location);
-        breaks.setLocationBreakpoint(0, location, null, null);
-        targets=session.getTargets();
-        /* We better only have one target connected to this session or 
something
-         * is not right...
-         */      
-        assertTrue(targets.length==1);
-        /* Resume the target, this should cause it to run till it hits the
-         * breakpoint
-         */
-        targets[0].resume();
-        /**
-         * Give the process up to 10 seconds to become either 
terminated or
-         * suspended.  It sould hit the breakponint almost immediatly 
so we
-         * should only sleep for max 100 ms
-         */
-        for (int x=0;x<100;x++) {
-            if (targets[0].isTerminated() || targets[0].isSuspended())
-                break;
-            Thread.sleep(100);
-        }
-        assertTrue(targets[0].isSuspended());
-        assertNotNull("PR:24183", 
targets[0].evaluateExpressionToValue("a"));
-        /* clean up the session */
-        session.terminate();
-
+        /***
+         * Tests to come
+         */       
   
   }



Alain Magloire wrote:

> Proposed patch to get the tests to compile(this is not applied, do not have
> the permission)
>
> 2002-10-30 Alain Magloire
>
> 	* core/org/eclipse/cdt/debug/core/tests/TargetTests.java: Test number
> 	24183 is no longer valid, the method was remove from the CDI API.
>
>
> Index: core/org/eclipse/cdt/debug/core/tests/TargetTests.java
> ===================================================================
> RCS file: /home/tools/org.eclipse.cdt.debug.ui.tests/core/org/eclipse/cdt/debug/core/tests/TargetTests.java,v
> retrieving revision 1.1
> diff -u -r1.1 TargetTests.java
> --- core/org/eclipse/cdt/debug/core/tests/TargetTests.java	10 Oct 2002 18:22:09 -0000	1.1
> +++ core/org/eclipse/cdt/debug/core/tests/TargetTests.java	30 Oct 2002 19:34:42 -0000
> @@ -134,7 +134,7 @@
>             Thread.sleep(100);
>         }
>         assertTrue(targets[0].isSuspended());
> -        assertNotNull("PR:24183", targets[0].evaluateExpressionToValue("a"));
> +        //assertNotNull("PR:24183", targets[0].evaluateExpressionToValue("a"));
>         /* clean up the session */
>         session.terminate();
>
>
> _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-patch
>