Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-patch] new methid to ICDIMemoryManager

	In the memory manager a string should be allowed to
	create a block since an expression can be use.
	
	* src/.../debug.core.cdi/ICDIMemoryManager.java (createMemoryBlock):
	 New method that takes a string as the first argument.
	
	* src/.../mi/core/cdi/MemoryManager.java (createMemoryBlock):
	New method that takes a string instead of a long, rearrange
	the method for it.



Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.debug.core/ChangeLog,v
retrieving revision 1.18
diff -u -r1.18 ChangeLog
--- ChangeLog	15 Oct 2002 21:42:17 -0000	1.18
+++ ChangeLog	17 Oct 2002 14:28:11 -0000
@@ -1,3 +1,11 @@
+2002-10-16 Alain Magloire
+
+	In the memory manager a string should be allowed to
+	create a block since an expression can be use.
+	
+	* src/.../debug.core.cdi/ICDIMemoryManager.java (createMemoryBlock):
+	 New method that takes a string as the first argument.
+	
 2002-10-15 Mikhail Khodjaiants
 	* CDebugModel.java: Implementing the memory view support.
 	* ICMemoryManager: Implementing the memory view support.
Index: src/org/eclipse/cdt/debug/core/cdi/ICDIMemoryManager.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/cdi/ICDIMemoryManager.java,v
retrieving revision 1.3
diff -u -r1.3 ICDIMemoryManager.java
--- src/org/eclipse/cdt/debug/core/cdi/ICDIMemoryManager.java	13 Oct 2002 02:33:21 -0000	1.3
+++ src/org/eclipse/cdt/debug/core/cdi/ICDIMemoryManager.java	17 Oct 2002 14:28:11 -0000
@@ -24,6 +24,16 @@
 	 * @return a memory block with the specified identifier
 	 * @throws CDIException on failure. Reasons include:
 	 */
+	ICDIMemoryBlock createMemoryBlock(String address, int length) throws CDIException;
+
+	/**
+	 * Returns a memory block specified by given identifier.
+	 * 
+	 * @param address 
+	 * @param length - how much for address
+	 * @return a memory block with the specified identifier
+	 * @throws CDIException on failure. Reasons include:
+	 */
 	ICDIMemoryBlock createMemoryBlock(long address, int length) throws CDIException;
 
 	/**
Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.debug.mi.core/ChangeLog,v
retrieving revision 1.8
diff -u -r1.8 ChangeLog
--- ChangeLog	13 Oct 2002 02:35:02 -0000	1.8
+++ ChangeLog	17 Oct 2002 14:28:28 -0000
@@ -1,3 +1,9 @@
+2002-10-16 Alain Magloire
+
+	* src/.../mi/core/cdi/MemoryManager.java (createMemoryBlock):
+	New method that takes a string instead of a long, rearrange
+	the method for it.
+
 2002-10-12 Alain Magloire
 
 	There are some serious problems with gdb/mi, for example
Index: src/org/eclipse/cdt/debug/mi/core/cdi/MemoryManager.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.debug.mi.core/src/org/eclipse/cdt/debug/mi/core/cdi/MemoryManager.java,v
retrieving revision 1.6
diff -u -r1.6 MemoryManager.java
--- src/org/eclipse/cdt/debug/mi/core/cdi/MemoryManager.java	13 Oct 2002 01:58:21 -0000	1.6
+++ src/org/eclipse/cdt/debug/mi/core/cdi/MemoryManager.java	17 Oct 2002 14:28:28 -0000
@@ -34,10 +34,18 @@
 	 */
 	public ICDIMemoryBlock createMemoryBlock(long address, int length)
 		throws CDIException {
+		String addr = "0x" + Long.toHexString(address);
+		return createMemoryBlock(addr, length);
+	}
+		
+	/**
+	 * @see org.eclipse.cdt.debug.core.cdi.ICDIMemoryManager#createMemoryBlock(string, int)
+	 */
+	public ICDIMemoryBlock createMemoryBlock(String address, int length)
+		throws CDIException {
 		MISession mi = getCSession().getMISession();
 		CommandFactory factory = mi.getCommandFactory();
-		String addr = "0x" + Long.toHexString(address);
-		MIDataReadMemory mem = factory.createMIDataReadMemory(0, addr, MIFormat.HEXADECIMAL, 1, 1, length, null);
+		MIDataReadMemory mem = factory.createMIDataReadMemory(0, address, MIFormat.HEXADECIMAL, 1, 1, length, null);
 		try {
 			mi.postCommand(mem);
 			MIDataReadMemoryInfo info = mem.getMIDataReadMemoryInfo();



Back to the top