Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[Cdt-launch-inbox] [Bug 126025] New: CApplicationLaunchShortcut call to ebugUITools.saveAndBuild is redundant

https://bugs.eclipse.org/bugs/show_bug.cgi?id=126025 
Product/Component: CDT / cdt-launch

           Summary: CApplicationLaunchShortcut call to
                    ebugUITools.saveAndBuild is redundant
           Product: CDT
           Version: 3.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P3
         Component: cdt-launch
        AssignedTo: cdt-launch-inbox@xxxxxxxxxxx
        ReportedBy: andrew.ferguson@xxxxxxx


hi,

 following on from 124519, the call to DebugUITools.saveAndBuildBeforeLaunch()
from

   org.eclipse.cdt.launch.internal.CApplicationLaunchShortcut.launch(IBinary
bin, String mode)

is now redundant as DebugUITools.launch invokes
DebugUIPlugin.launchIn(Background|Foreground) which copes with save/build
concerns.

DebugUITools.saveAndBuildBeforeLaunch() is deprecated on HEAD for this reason

Since CApplicationLaunchShortcut.launch(IBinary, String) now invokes
DebugUITools.launch because of 124519, its enough to remove the call to
saveAndBuildBeforeLaunch()

does this require a patch submission? (it has to go through our internal
contribution procedures if so :)

thanks,
Andrew




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Back to the top