[cdt-dev] Review help needed for C++20 change

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

Hi CDT devs,

Igor has provided a PR to add some support for part of C++20.

Is anyone able to review this code?

Alexander has provided the process feedback to Igor already (thanks Alexander).

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

---------- Forwarded message ---------
From: Igor V. Kovalenko <notifications@xxxxxxxxxx>
Date: Sun, 11 Dec 2022 at 14:06
Subject: [eclipse-cdt/cdt] Add basic support for c++20 three-way comparison operator (PR #219)
To: eclipse-cdt/cdt <cdt@xxxxxxxxxxxxxxxxxx>
Cc: Subscribed <subscribed@xxxxxxxxxxxxxxxxxx>

This adds initial support for operator<=>, corresponding Lexer option is enabled if __cpp_impl_three_way_comparison feature-test macro is found.

Support is very rudimentary (e.g. return type deduction is not implemented, _expression_ evaluation is not handled etc..)

---

You can view, comment on, or merge this pull request online at:

  https://github.com/eclipse-cdt/cdt/pull/219

Commit Summary

• 8483ae5 Add basic support for c++20 three-way comparison operator

File Changes

(18 files)

• M core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/scanner/LexerTests.java (23)
• M core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/model/ASTStringUtil.java (2)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/ASTSignatureUtil.java (3)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/IASTBinaryExpression.java (6)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/parser/IToken.java (2)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/parser/Keywords.java (1)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ASTAmbiguousBinaryVsCastExpression.java (10)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/AbstractGNUSourceCodeParser.java (4)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ValueFactory.java (3)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/c/CASTBinaryExpression.java (4)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/c/GNUCSourceParser.java (1)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/GNUCPPSourceParser.java (1)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/OverloadableOperator.java (10)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/BuiltinOperators.java (4)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalBinary.java (5)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/scanner/CPreprocessor.java (5)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/scanner/Lexer.java (9)
• M core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/scanner/TokenUtil.java (3)

Patch Links:

• https://github.com/eclipse-cdt/cdt/pull/219.patch
• https://github.com/eclipse-cdt/cdt/pull/219.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <eclipse-cdt/cdt/pull/219@github.com>