[cdt-dev] Fwd: Re: Change 154830 in cdt/org.eclipse.cdt[master]: Bug 558

[sergei.kovalchuk@xxxxxxxxxx]

Thanks a lot!
To proceed the cleanup story in "org.eclipse.cdt.ui" bundle, I would 
like to change the deprecated type for public API
from  "CUIPlugin: public ContextTypeRegistry 
getCodeTemplateContextRegistry()"
to    "CUIPlugin: public ContributionContextTypeRegistry 
getCodeTemplateContextRegistry()".

Currently, inside the "cdt" repository we have
the next sensitive dependency:

1) org.eclipse.cdt.internal.corext.template.c
    FileTemplateContext
    FileTemplateContext(String, String)
2) org.eclipse.cdt.internal.ui.preferences
    CodeTemplateBlock
     edit(TemplatePersistenceData, boolean)
     getFileTemplateContextRegistry()
     updateSourceViewerInput(List<Object>)
3)org.eclipse.cdt.ui
    CUIPlugin
      getCodeTemplateStore()


Could I have "approve" for such changes?


Best Regards,
Sergei.



On 2019-12-20 15:53, Jonah Graham (Code Review) wrote:
> Jonah Graham has posted comments on this change. (
> https://git.eclipse.org/r/154830 )
>
> Change subject: Bug 558474 - [CDT]CleanUp deprecated methods
> ......................................................................
>
>
> Patch Set 6: Code-Review+2
>
> LGTM
>
> Thank you and well done on your first CDT Gerrit.
>
>
> --
> To view, visit https://git.eclipse.org/r/154830
> To unsubscribe, visit https://git.eclipse.org/r/settings
>
> Gerrit-Project: cdt/org.eclipse.cdt
> Gerrit-Branch: master
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Iff82715d7415d0512a8a1fe3f9625e7c27fb01d8
> Gerrit-Change-Number: 154830
> Gerrit-PatchSet: 6
> Gerrit-Owner: Sergei Kov <sergei.kovalchuk@xxxxxxxxxx>
> Gerrit-Reviewer: Alexander Fedorov <alexander.fedorov@xxxxxxxxxx>
> Gerrit-Reviewer: CDT Bot <cdt-bot@xxxxxxxxxxx>
> Gerrit-Reviewer: Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
> Gerrit-Comment-Date: Fri, 20 Dec 2019 12:53:00 +0000
> Gerrit-HasComments: No