Re: [cdt-dev] Ping review (2)

[Marc-Andre Laperle <malaperle@xxxxxxxxx>]

Hi Macro,

Thank you for all the great work! One thing I have been wondering is if we should go ahead with adding a lot of new checkers or not in Codan. My worry is that we have a lot to maintain and false positives can be a recurring problem. There are also a lot of tools that have mostly replaced the need of Codan like clang-tidy, clang-static-analyzer, pc-lint, Cppcheck etc. Clangd also covers a lot through warnings and errors that come directly from the compiler and does so as-you-type.
I am not saying that I am against adding more checkers and I don’t want to discourage you from improving CDT in this area. But this concern has been at the back of my mind and I’d love to hear your thoughts (or anyone’s) on the subject,

Otherwise, I’m happy to help reviewing where (when?) I can. (Well, except the formatter, I don’t know much about!).

Regards,
Marc-André

> On Apr 17, 2019, at 12:27 PM, marco <marco.stornelli@xxxxxxxxx> wrote:
> 
> Hi guys,
> 
> first of all thanks to everyone for comments received about merged commits. However there are a lot of them without feedback, the effort for the rebase each time is high, so please review the commits. Thanks!
> 
> Current status:
> 
> Formatter bug fixes with higher priority:
> Bug 405409 - Formatting namespaces with inactive sections
> Bug 376395 - Fix const methods with never join wrapped lines
> Bug 546221 - Fix exception for nested namespaces
> Bug 390324 - Fix cast operator containing func declarator
> 
> Formatter improvements
> Bug 500000 - Added proper formatting for lambda expressions
> Bug 461435 - Added options to format pointers in methods (ready to be merged @Jonah can you do it?)
> 
> Codan improvements
> Bug 545954 - Added checker for functions/methods blacklist
> Bug 545959 - Added checker for assignment operator
> Bug 545702 - Added new checker to verify copyright information
> Bug 545714 - Added a shallow copy checker
> Bug 545956 - Added checker for virtual methods in ctor/dtor
> Bug 546173 - Add a check for returning of local variable addresses
> Bug 545977 - Added checker for variable initialization
> Bug 545704 - Added checker for float comparison
> Bug 343274 - Added checker for const and static methods check
> Bug 545952 - Added checker to check for goto usage
> Bug 355174 - Added cheker for missing case in a switch
> 
> New UI feature
> Bug 546395 - Added "copy qualified name" feature
> 
> Refactoring
> Bug 303870 - Add override virtual methods functionality (ready to be merged after review)
> 
> Codan fix
> Bug 545877 - Don't take into account init var values in CFG
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/cdt-dev