Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Formatting and EPLv2
Thanks Jonah!

Sent from my BlackBerry - the most secure mobile device - via the Rogers Network
From: jonah@xxxxxxxxxxxxxxxx
Sent: November 22, 2018 5:14 PM
To: cdt-dev@xxxxxxxxxxx
Reply-to: cdt-dev@xxxxxxxxxxx
Subject: Re: [cdt-dev] Formatting and EPLv2

Hi folks,

I am just about to submit updating CDT to EPLv2 and normalizing/enforcing the formatting of the code base. To save me having to rebase anything again I would appreciate it if no one commits anything to cdt master until I have submitted everything. I will send another message out once the submission is complete.

Once in, please let me know if you are having trouble rebasing your change/gerrit onto the newly formatted code base.

Finally, please don't forget to reformat/cleanup/check license on any code you are adding. The license is now EPLv2.

My changes include a script (releng/scripts/change_to_eplv2.sh) which I used to automate the change across CDT's codebase.

Thanks
Jonah
 

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On Tue, 23 Oct 2018 at 05:49, Marc-Andre Laperle <malaperle@xxxxxxxxx> wrote:
I welcome the formatting as I find the code to be all over the place stylistically which can mean more confusion for contributions and worsened perception of quality. 
Can we also remove the trailing white space too? I find that weirdly annoying. There is a manually "clean-up” check box for it and save action.
Also, I guess Tabs win? :) I don’t mind personally but was expecting more heated debate!

About EPLv2, I don’t know much about that. It doesn’t look like there is any downside? I guess it opens the door to a secondary license of GPL which I don’t foresee anyone to be actively against, especially since the secondary license can be dropped by adopters.

Cheers,
Marc-André

On Oct 22, 2018, at 10:28 AM, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

Hi folks,

A bunch of committers, contributors and adopters are all together at EclipseCon Europe for the Embedded Summit. We have had many discussions about lots of exciting things and a great roadmap is starting to develop. Watch this space for more on that.

We also discussing some more releng / housekeeping stuff and that is the purpose of this email.

I am planning on updating CDT to EPLv2 and normalizing/enforcing the formatting of the code base. The committers who are here are all in agreement, but I want to notify the larger community and find a time that will interfere as little as possible. These changes will mean all source files are touched so automatic merging will be affected. 

I would like to apply these changes the week of the 12th of November (week after 2018-12 M2).

Please speak up if the timing causes you an issue by commenting on the bug report. 

Thanks,
Jonah



~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev

Back to the top