Re: [cdt-dev] Formatting and EPLv2

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

As I understand the upgrade to EPLv2 has to happen at some point, so now, while doing formatting, seems a good time.

Yes, I'll make sure trailing spaces are removed and enforced with save actions too. 

As for tabs vs spaces I just like the idea of keeping the standard the same as Eclipse defaults as much as possible. That will make it easier to evolve as Eclipse evolves as a whole. 

There are a whole lot of other stylistic things beyond whitespace, but they are for another day. My personal annoyance is the lack of consistency about whether f is used as prefix for fields or not - my preference is not because the fields are already rendered differently by the editor. Also the overuse of final for local variables. Both of these could also be enforced by cleanup on save actions, however I don't know how to even start gaining concensus. 

Jonah 

On Tue, 23 Oct 2018, 09:34 Corbat Thomas, <thomas.corbat@xxxxxx> wrote:

> Also, I guess Tabs win? :) I don’t mind personally but was expecting more heated debate!

 

If I knew this was debatable, I would have voted for 4 spaces… J

 

On Oct 22, 2018, at 10:28 AM, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

 

Hi folks,

 

A bunch of committers, contributors and adopters are all together at EclipseCon Europe for the Embedded Summit. We have had many discussions about lots of exciting things and a great roadmap is starting to develop. Watch this space for more on that.

 

We also discussing some more releng / housekeeping stuff and that is the purpose of this email.

 

I am planning on updating CDT to EPLv2 and normalizing/enforcing the formatting of the code base. The committers who are here are all in agreement, but I want to notify the larger community and find a time that will interfere as little as possible. These changes will mean all source files are touched so automatic merging will be affected. 

 

I would like to apply these changes the week of the 12th of November (week after 2018-12 M2).

 

Please speak up if the timing causes you an issue by commenting on the bug report. 

 

Thanks,

Jonah

 

 

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev

 

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev