Re: [cdt-dev] Parser fix needed for correct parsing of GCC 8 standard li

[Marc-Andre Laperle <malaperle@xxxxxxxxx>]

PDE’s API tooling should display an error if there is a problem. But sometimes you have to do a clean/full-build for errors to appear. So I would do that just to be sure. I’ll review your patch either way!
Cheers.

> On Sep 15, 2018, at 8:41 PM, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:
> 
> Hi Marc-André,
> 
> Thanks for the suggestion!
> 
> I made an attempt to backport the fix to the 9.5 branch based on this approach:
> 
> https://git.eclipse.org/r/#/c/129478/
> 
> Is there a way to verify that everything is OK API-wise?
> 
> Thanks,
> Nate
> 
> ________________________________________
> From: cdt-dev-bounces@xxxxxxxxxxx <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Marc-Andre Laperle <malaperle@xxxxxxxxx>
> Sent: September 15, 2018 11:58 PM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] Parser fix needed for correct parsing of GCC 8 standard library headers
> 
> Hi Nathan,
> I think this is a good case for using some API filters or even better and if possible tag the new APIs as @noextend and/or @noreference instead. Then in 9.6 you can remove those.
> Marc-André
> 
> 
>> On Sep 15, 2018, at 7:48 PM, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:
>> 
>> Hi all,
>> 
>> It has recently come to my attention that in the libstdc++ (standard library) version that ships with GCC 8, the implementation of the std::is_constructible type trait has been updated to use a new compiler intrinsic __is_constructible, which CDT's parser does not currently recognize.
>> 
>> This type trait is used in the signature of several commonly used standard library functions, such as std::map::insert(), and as a result, the parser can produce false-positive errors at the call sites of such functions, which is fairly noticeable.
>> 
>> I have added parser support for this intrinsic in bug 539052 [1]. However, the design of our parser means that a change like this requires adding new API (since it involves adding a new keyword, a new token type, etc.). This means that while I can commit the fix to the 9.6 branch, it's not easy to backport it to the 9.5 branch.
>> 
>> My understanding is that the current plans are to release CDT 9.6 as part of the 2018-12 simultaneous release. Do we have any options for getting this fix in front of users sooner? As people start upgrading their compilers to GCC 8, they are likely to start noticing this more and more.
>> 
>> Regards,
>> Nate
>> 
>> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=539052
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> 
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/cdt-dev