Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Code review request for patches for parallel build (internal builder)

Hi Samuel,

You can push these as dependent gerrits by having the git revisions depending on each other. i.e. have the commit for 2 & 3 have 1 as a parent commit. In the top right of the gerrit interface you will see Related Changes and/or Submitted Together. See https://git.eclipse.org/r/#/c/119761/ and https://git.eclipse.org/r/#/c/119760/ for a recent example of two gerrits I submitted together.

HTH
Jonah


~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On 16 April 2018 at 15:39, Samuel HULTGREN <samuel.hultgren@xxxxxx> wrote:

Hi all,

 

We have a few patches to fix three separate issues for the internal builder when using parallel build.

These issues are:

1.       Incremental build always does full rebuild (https://bugs.eclipse.org/bugs/show_bug.cgi?id=217674) (gerrit: https://git.eclipse.org/r/#/c/121151/)

2.       Pre- and post build steps are not executed (https://bugs.eclipse.org/bugs/show_bug.cgi?id=528940)

3.       Performance issue when pressing build on already built project (no Bugzilla yet, but will come soon)

 

All these three separate issues are fixed by changing the same class file, ParallelBuilder.java in the org.eclipse.cdt.managedbuilder.core plugin.

 

The issues are separate but the fixes for 2 and 3 depends on 1.

 

The question we have is, how to push this to gerrit in a good way?

 

Kind regards,

Samuel Hultgren


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top