BTW, Jonah, when you say the change broke tycho/maven, what exactly broke? The builds seem fine.
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of Doug Schaefer
Sent: Sunday, October 8, 2017 2:00 PM
To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] CDT 9.3.3
To allow for UI tests to include CDT features, we have found that the test plug-ins need to be last in the build. Flattening should work. Where the modules are listed shouldn’t matter.
I also wonder if our root problem is that the features need to be in a features directory that has a pom file with the features groupId on it. I believe the pom-less projects inherit the groupId from the pom file in the immediate parent
directory. Be worth a try. Our goal should be to have pom-less projects wherever possible.
I have fixed the version numbers in the features[1]. I also fixed the pom's so that the (nearly) single-line command works properly to update the versions[2]. In addition I documented the command on the releng page[3].
That said, the master branch has had some re-jigging done to the pom.xmls which broke tycho/maven[4]. This is because this change has the root refer to modules two levels deeper, but those module's refer to their immediate parent directory
implicitly because of pomless builds. I'll try and fix this, but can you confirm the (secondary - pom.xml changes) purpose of [4] was that build would run before test? If so, can you do "mvn package && mvn verify" instead of flattening everything into root
pom? If that works, I would like to revert the secondary - pom.xml changes.
On 7 October 2017 at 11:26, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
OK, I am updating the feature versions now.
Cool. Sounds good.
One of the unfortunately things we’ll need is to update the features to version 9.3.3. There’s almost 20 of them so it’s a bit painful. Jonah, could you check into that.
Thanks!
Doug.
I’ve just cherry-picked the fix for Bug 525645 to the CDT 9.3 branch (not in Gerrit as I had a merge-conflict) and set the milestone to 9.3.3.
When Jenkins is happy with it, I’ll submit it.
https://git.eclipse.org/r/#/c/106354/
Then I’m good to go for 9.3.3
BR
Thomas
From:
cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of Jonah Graham
Sent: Freitag, 6. Oktober 2017 14:20
To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] CDT 9.3.3
I have now created the bugs that I intend to fix for 9.3.3:
They are all fairly small changes (but with big user impact) to fix NPEs and similar type problems.
On 5 October 2017 at 11:08, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
Hi folks,
As discussed at the CDT monthly I would like to have a bug fix release (CDT 9.3.3) soon. I believe I will be ready by Tuesday for this.
The improvements are some debug bug fixes. I will create the target milestone and assign bugs to them later today/tomorrow.
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev
|
