Re: [cdt-dev] Bug 303870 - override virtual method functionality

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

Hi Pavel,

Thank you for your contribution to CDT. It probably makes sense to squash all commits into one and then upload it to Gerrit against master.

-sergey

On Fri, Oct 6, 2017 at 8:48 AM, Pavel Marek <pavel.akira.marek@xxxxxxxxx> wrote:

​Dear Mr Prigogin,

I have implemented override virtual method functionality. This is my first Eclipse CDT contribution and I am confused about how should I push the changes into gerrit: 

  I have a local branch "overridemethods" (I have basically just added new package into refactorings - similar to "generate getters and setters", while keeping changes to existing code as small as possible). Every commit in "overridemethods" branch lacks "Change-Id" in messages.

Should I somehow add Change-Ids to every commit message in the "overridemethods" branch and rebase it onto master? Or should I just merge and this way create one big commit (13 files added)?

Thank you in advance for any advices.

Regards,

Pavel Marek