Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Merging GitHub pull requests

Hi Madura,

Unfortunately the github CDT is just a mirror of

Please submit this to gerrit
& and I will
have a review.

As a preliminary review, please consider the error handling in your
new code. In particular this code block

+ } catch (Exception e) {
+ // TODO Auto-generated catch block
+ e.printStackTrace();
+ }

I will need steps to reproduce the problem too, so that I can test the change.

I have raised to
address that PRs on GitHub look like an ok place to submit to.

Jonah Graham
Kichwa Coders Ltd.

On 10 August 2017 at 07:52, Madura Anushanga <madura.x86@xxxxxxxxx> wrote:
> Hi,
> I have added a PR[1] for adding support for newer MSVC versions with CDT, it
> has been on github eclipse repo for a long time without being rejected or
> merged. Please comment.
> 1.
>             - Madura A.
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit

Back to the top