Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Change in

Hi Sergey,

That patch is fine for now as the API change is new.  I think that the changeEvent(int type) method should change
its signature to be changeEvent(IDockerConnection conn, int type) so that the class connection
variable is not overridden and conn is ignored.

-- Jeff J.

----- Original Message -----
> Hi Jeff,
> Please review the change
> in
> launch/org.eclipse.cdt.docker.launcher/src/org/eclipse/cdt/internal/docker/launcher/
> that I made to fix the broken build. Thank you.
> -sergey

Back to the top