Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Make Targets UI change
Thanks Axel. I’ll leave it there. Again, I was never planning on removing it, just removing it from the default CPerspective layout. Having it always visible has always been suspect especially when using build systems that don’t really support Make targets, like the internal builder.

But I’ll leave this for now until people get used to the new layout and see what everyone thinks. Better to removing things at the major release cycle (I.e. for Oxygen) anyway where we can get everyone’s thoughts. For now, you can use either.

Also, I’m not changing any of the actions, just making them work in the Project Explorer as well.

Doug.

From: <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Axel Müller <axel.carl.mueller@xxxxxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Monday, August 15, 2016 at 2:11 PM
To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] Make Targets UI change

-1 for removing the Make Targets view from the C  perspective
I am a heavy user of the Make Targets view. But first let me describe my workspace.
I am using CMake add build tool and doing out-of-source builds (which is the preferred default for cmake) i.e. my build output is not in the source tree but in an additional directory which is usually parallel to the source directory

src
build-gcc-32-debug
build-clang-64-release
...
CMake will then create various Makefiles in the build tree.
There can be more than one build output directory depending on your tool chain and its settings. Usually the build output tree is identical to the source tree. But this is not mandatory, e.g. some directories could be excluded because they are only for Windows and you are working on Linux at the moment or you want to combine some targets in one folder etc. That's no problem for the Make Targets view as I am using there the build tree and not the source tree.

In our build tree we have a lot of make targets (single or multiple executables, libraries, unit tests, generators for internalization language files, etc.). But for my daily work I only need a handful of these targets. So I define these targets in the Make Targets view (they can be in different subfolders) and then I enable the wonderful feature "Hide folders without targets". Thus, my Make Targets view shows only the folders in the build tree that I really need! Much less clutter.

The next disadvantage I see with the targets in the Project Explorer view is the case when I am working on a source file in library and have "Link with editor" enabled. However, my make target (the executable) is in a different folder of the tree. I would have to scroll there first. This is not the case for the Make Targets view which can have focus different from the Project Explorer.

I can see some advantages of your approach if your project is small and only has a small amount of targets. But as soon as you have a large build tree with many targets the Make Targets view is much better.

Ah, and what about the key binding for "Build last make target"? Will it still work? This is a must have.

  Axel


Am 15.08.2016 18:32 schrieb "Doug Schaefer" <dschaefer@xxxxxxxxxxxxxx>:
From: <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Monday, August 15, 2016 at 11:22 AM

To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] Make Targets UI change

+1 for adding them to the Project Explorer, I think this is fairly obvious to users, however:

Yeah, this should have been done a long time ago, but anyway…

-1/4 (i.e not full objection, but slight objection) for removing the Make Target View from C Perspective.  Reason is that the context of Make view is quite different from Project Explorer, especially if you have Link With Editor selected. 

It’s there for people who still need it (and when upgrading workspaces, it won’t be removed). I think for the vast majority, people are likely confused by it since you generally don’t need Make Targets when building CDT projects. Luckily the Outline view has hid it since forever so it doesn’t really get in the way.

Though if there’s mass outrage, I will leave it. :).


~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On 15 August 2016 at 16:09, Doug Schaefer <dschaefer@xxxxxxxxxxxxxx> wrote:
Hey gang,

I’ve been doing some work on a QNX BSP which uses Make Targets. I eventually got really annoyed that they are in a separate view and not in the Project Explorer.

So, as it turns out, the Common Navigator Framework makes this pretty easy and I’d like to contribute it in 9.1. As part of this, I plan on removing the Make Target View from the CPerspective default layout. I won’t delete the View in case someone really wants it. But once you see Build Targets (I renamed them too since they aren’t really tied to Make), you won’t want to go back :).

Let me know if you have concerns. Here’s a sneak peek. Still some workflow issues to work out before I commit it. Should be done by end of day or tomorrow.


Doug.
---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev

 ---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Back to the top