Re: [cdt-dev] expand vertical ruler hover icons in the CDT editor by def

[William Riley <william.riley@xxxxxxxxxxx>]

Hi Alexander

>From the comments in JDT's code some parts of this were originally in platform text, however it got moved to JDT UI in 2006.

There are 2 classes (AnnotationExpandHover & AnnotationExpansionControl) which could be moved back to platform as they contain no code which needs to be specific to JDT or CDT, these also contain the majority of the implementation. At the moment the CDT copy does contain a few enhancements I made over JDT which I will be trying to push back to them.

There is one potential issue, during the port to CDT I reverted a bugfix made by JDT (165533) to fix a bug where a single click on the 1st icon would trigger both its own action & the top action on the ruler underneath. The original JDT bug does not affect CDT but might still affect JDT so there is some work involved here to check this and then maybe find a way to fix both bugs. It might be easier to resolve this if these classes were in the platform, as is it appears to be caused by a difference in the SWT mouse events in use by the expand control & the editor's ruler column. I will be raising this bug against JDT and giving them the information I gathered so far, but if the original bug still affects JDT I might not be able to put enough time in to fix this.

Regards
William

-----Original Message-----
From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Aleksandar Kurtakov
Sent: 03 August 2016 06:44
To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] expand vertical ruler hover icons in the CDT editor by default



----- Original Message -----
> From: "Jonah Graham" <jonah@xxxxxxxxxxxxxxxx>
> To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
> Sent: Wednesday, 3 August, 2016 12:19:09 AM
> Subject: [cdt-dev] expand vertical ruler hover icons in the CDT editor bydefault
>
> Hello CDT folk,
>
> At the CDT monthly call today [1] we discussed the Bug 476797 [2]
> which is a great feature from JDT ported by William Riley of Renesas
> to CDT. The feature is to expand the vertical ruler when there is more
> than one marker on the given line. A screenshot of what it looks like
> (in JDT) is available in the bug [3].
>
> William did some of the work at the Hackathon at ECNA and has improved
> and refined the solution since then. It is now in good shape and,
> following discussions on the call today, we plan to turn it on by
> default in the CDT editor in CDT 9.1 (aka Neon.1). William is also
> planning to spend some time next month applying his improvements to
> the JDT editor with the hope of changing the JDT default in the
> future.
>
> If you have any concerns on this plan, I would be grateful if you
> raised them in the bug [2].

Has anyone looked into the possibility of moving this code into lower layer so JDT and CDT pick it from there instead of copying it around? If you have any ideas (even if not full featured but having only small subset shared for now) let's discuss them and try to enhance Platform.

>
> Thanks,
> Jonah
>
>
> [1] https://wiki.eclipse.org/CDT/calls/Aug2016
> [2] http://eclip.se/476797
> [3] https://bugs.eclipse.org/bugs/attachment.cgi?id=256421
>
> ~~~
> Jonah Graham
> Kichwa Coders Ltd.
> www.kichwacoders.com
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>

--
Alexander Kurtakov
Red Hat Eclipse team
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/cdt-dev



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.