Re: [cdt-dev] proposal for side-stepping known test failures

[Andrew Gvozdev <angvoz.dev@xxxxxxxxx>]

Hi John,

This approach does not look particularly scalable. Is it intended that every commiter will add to the CDT code filters for individual tests that fail in his/her environment?

// Consistently fails, and, yes, I do have Cygwin in my PATH

if (System.getProperty("cdt.skip.known.test.failures") != null) { //$NON-NLS-1$

return;

}

Why don't create a bug in bugzilla instead to fix the problem for good?

Thanks,

Andrew

On Fri, Aug 17, 2012 at 12:49 PM, Cortell John-RAT042 <RAT042@xxxxxxxxxxxxx> wrote:

I was able to resolve roughly a dozen intermittent failures caused by a bug in

 

   org.eclipse.cdt.ui.tests.BaseUITestCase.checkTreeNode(IViewPart, int, String)

 

The implementation searched the entire workbench for the SWT Tree instead of just the given view.  This would intermittently (but frequently enough) return, e.g., the Outline view’s tree because it has a root element with the same label as that in the Call hierarchy view. It was just a matter of the order in which the controls in the workbench were found, which is undefined and inconsistent.

 

So, here we have an example of a test being unreliable, unrelated to OS or environment. The test had a bug and you and Hudson were simply getting lucky.

 

I’ve pushed the fix to master.

 

John

 

 

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Andrew Overholt
Sent: Friday, August 17, 2012 7:44 AM

To: CDT General developers list.
Subject: Re: [cdt-dev] proposal for side-stepping known test failures

 

> Since we don't have Hudson on Windows

There is a Windows Hudson slave, isn't there?  A job could be set up to run either the full CDT build or just the tests on it.

Andrew

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev