Re: [cdt-dev] MIMemory oddity.

[Pawel Piech <pawel.piech@xxxxxxxxxxxxx>]

I think you're right on: looks like a minor bug.

On 05/18/2012 02:06 PM, Dave Korn wrote:
>      Hello list,
>
>    I noticed something that looked strange in MIMemory.java
> (org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service), in the
> MIMemoryCache.getMemory method.  There's a DataRequestMonitor handleSuccess
> method in there that looks like this:
>
> 	protected void handleSuccess() {
> 		MemoryByte[] block = new MemoryByte[count];
> 		block = getData();
> 		MemoryBlock memoryBlock = new MemoryBlock(startAddress, length, block);
> 		fMemoryBlockList.add(memoryBlock);
> 		countingRM.done();
> 	}
>
>    It looks to me like that's creating a new array of MemoryByte[count] and
> then immediately discarding it, needlessly.  I'm only asking in case there's
> something I don't understand about java type resolution and generics.  (And if
> that were the case, surely a MemoryByte[0] would suffice?)
>
>      cheers,
>        DaveK
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev