Re: [cdt-dev] Failed pre-launch check

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Jason Litton
> Sent: Tuesday, April 10, 2012 3:28 PM
> To: CDT General developers list.
> Subject: [cdt-dev] Failed pre-launch check
> 
> I just uncovered this behavior and I'm not sure if it's a bug 
> or expected. If my GdbLaunchDelegate returns false in 
> preLaunchCheck, my GDB session is not launched, but the DSF 
> session associated with it is not ended. So any of my 
> SessionEndedListeners aren't notified of the failed launch, 
> and still think they're doing something. Is this the expected 
> behavior here, or is it a bug?

Bug.

We fixed this in https://bugs.eclipse.org/bugs/show_bug.cgi?id=374374

If you return false in your own preLaunchCheck code, you will need
something like this:

boolean result = super.preLaunchCheck(config, mode, monitor);
if (!result) {
  // The launch will not proceed!  We must cleanup.
  cleanupLaunch();
}
return result;