Re: [cdt-dev] Bug id labels in cvs commits

[Alex Blewitt <alex.blewitt@xxxxxxxxx>]

Just as a note: in Git, you don't typically put the bug in the first line - that's used to say what the patch achieves. 

You typically put additional key-value pairs at the bottom of the commit separated by a colon eg:

---8< ---

Adds LLVM support

LLVM is now recognised as a toolchain

and can compile on Windows, Linux and OSX

Bug: 12345

--- 8< ---

The use of "Bug" here isn't normative (other people use issue, ticket etc) but the Key-Value pair is standardised - as you can get with a Change-Id: and a Signed-off-by: values as well. 

I mention this for information purposes only in case a move to Git occurs in the future and you want to make the rules flexible for the future case.

Alex

Sent from my iPhone 4

On 11 Mar 2011, at 21:29, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx> wrote:

I also prefer when the bug # is at the start

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Andrew Gvozdev
Sent: Friday, March 11, 2011 4:00 PM
To: CDT General developers list.
Subject: Re: [cdt-dev] Bug id labels in cvs commits

-1 for zilla. That will deny hyperlinking to the bug in Mylyn.

Personally I much prefer a comment to start from bug id but regex is fine with me.

Andrew

On Fri, Mar 11, 2011 at 3:44 PM, Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx> wrote:

Can we make (.*\s|^)bug(zilla)?\s(\d+).* THE RULE? It appears to a a de-facto one.

-sergey

On Fri, Mar 11, 2011 at 12:40 PM, Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx> wrote:

It has to be a rule. If it is the rule I am fine. I am not big fan of
lots of variations. Personally BUG 1234 looks ugly.

On Fri, Mar 11, 2011 at 3:17 PM, Sergey Prigogin
<eclipse.sprigogin@xxxxxxxxx> wrote:
>
>
> On Fri, Mar 11, 2011 at 12:07 PM, Alena Laskavaia <elaskavaia.cdt@xxxxxxxxx>
> wrote:
>>
>> we still have people who do not understand the rule:
>> use
>> "Bug 12345 - comment"
>> format for comment in commits. How hard is that?
>
> Let me ask another question. How hard is it to make cvsgenie to use regular
> _expression_ pattern "(.*\s|^)bug(zilla)?\s(\d+).*"?
> -sergey
>>
>> These are the recent error from cvs genie
>>
>> ERROR 3: Possible invalid bug formating: "Auto indentation in calls to
>> template functions. Bug 314995.
>> ERROR 3: Possible invalid bug formating: "BUG 314055 - Updated build
>> files to add EDC docs manual to CDT build"
>> ERROR 3: Possible invalid bug formating: "Bugzilla 312098 : [Memory
>> Browser] do not create a rendering automatically when Memory Browser
>> is opened. Additional cleanup per John Cortell suggestions/issues.
>> ERROR 3: Possible invalid bug formating: "fix for  Bug 312011 -
>> Helios is missing several platforms
>> ERROR 3: Possible invalid bug formating: "further changes for  Bug
>> 291815 - fix test failure on UNIX/Linux"
>> ERROR 3: Possible invalid bug formating: "This is a continuation of
>> Bugzilla 312098 :  [Memory Browser] do not create a rendering
>> automatically when Memory Browser is opened. Changed the code dealing
>> with the Wrong _expression_ displayed to be used consistently.
>> ERROR 3: Possible invalid bug formating: "Workaround to get around bug
>> 214215
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
>

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev