[cdt-dev] RE: API tooling (was: [DSF] SessionType)

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

I meant: "it will increase the _chances_ of the patch being accepted"

It will not increase the "changes" of the patch :-) 

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Marc Khouzam
> Sent: Sunday, July 11, 2010 9:29 PM
> To: CDT General developers list.
> Subject: [cdt-dev] API tooling (was: [DSF] SessionType)
> 
> I wanted to take this opportunity to remind people that are 
> submitting patches for CDT that they should
> turn on API tooling as described (in 7 little steps) here: 
> http://wiki.eclipse.org/CDT/policy#Using_API_Tooling
> 
> This takes less than 30 seconds to do and will warn you of 
> any changes that break the API.
> It will make the review of the committer faster and will 
> increase the changes of the patch being accepted.
> The tool will automatically verify all the things we 
> mentioned in this thread, and many more.
> So, if you ever wonder: "Is this change allowed", you won't 
> have to ask anyone, the tool will tell you
> with an error.
> 
> Thanks
> 
> Marc
> 
> ________________________________________
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of John Cortell 
> [rat042@xxxxxxxxxxxxx]
> Sent: July 9, 2010 9:09 AM
> To: CDT General developers list.; 'Vladimir Prus'
> Cc: 'cdt-dev@xxxxxxxxxxx'
> Subject: RE: [cdt-dev] [DSF] SessionType
> 
> At 07:55 AM 7/9/2010, Marc Khouzam wrote:
> >  The problem is that your original suggestion added an method to an
> > interface.
> >
> >interface myInterfae {
> >   void foo();
> >}
> >
> >class myClass implements myInterface {
> >   void foo() { }
> >}
> >
> >If I add method bar() to myInterface, myClass will suddenly not
> >compile anymore
> >because it _must_ implement bar().
> 
> BTW, you can add a method to an interface that is @noextend and
> @noimplement without breaking backwards compatibility. I.e., if the
> interface is strictly something a client invokes, then a new method
> is a backward compatible extension of the interface.
> 
> 
> 
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev______________
_________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>