Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [cdt-dev] Disassembly view throws NPE when debugging with CDI

At 12:51 PM 6/17/2010, Andy Jin wrote:
There is a distinction between API method and non-API method. For API
method if it says to return null we'd better respect it. The method in
question "getTopStackFrame()" is an API method from
org.eclipse.debug.core.model.IThread.

Absolutely. I had not looked at the javadoc for the method; I was addressing the question generally. In this case, we can for sure say callers to IThread.getTopStackFrame() should check the return value for null. That said, that alone does not necessarily solve this problem. As you stated, there might be something deeper going wrong here. All we can say for sure is that the fix will include a check for null. I'll hopefully get to the bottom of this today.

John



Back to the top