RE: [cdt-dev] Final build available, tagged and branched

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

I've seen the problem when interrupting a running target
in non-stop mode.  

Looking at logs, it seems James' case was all-stop and
setting a breakpoint while the target was running (which
causes an interrupt).  But for this case to cause the problem,
it would also have to trigger opening a CSourceNotFoundEditor, 
and I haven't figured out how that would happen in this case...

So, I'm under the impression that the problem would not happen
often for all-stop, but much more for non-stop.

I agree that the fix is safe, but I also don't like last
minute changes.

Sigh...  Experience says not to commit..
But it's not my call.

Thanks

Marc


> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of John Cortell
> Sent: Tuesday, June 15, 2010 10:51 AM
> To: CDT General developers list.; CDT General developers list.
> Subject: Re: [cdt-dev] Final build available, tagged and branched
> 
> Well, the bug has been in since May 3rd, and except for James, it 
> appears none of us were seeing the issue.Then again, we don't do real 
> world testing, and I think James found it actually using the 
> debugger. Additionally, the fact that it was detected by Marc in a 
> smoke test is troubling. It's a tough call.
> 
> James, what's your take on the severity?
> 
> John
> 
> At 09:42 AM 6/15/2010, Doug Schaefer wrote:
> >My problem is that we're past the last minute. I need a sense of how
> >often this happens before withdrawing my objection.
> >
> >On Tue, Jun 15, 2010 at 10:34 AM, John Cortell 
> <rat042@xxxxxxxxxxxxx> wrote:
> > > Marc, I reviewed the change. IMO, it's perfectly safe to 
> put in at the last
> > > second as it  merely restores a code path that was there 
> before May 3.
> > >
> > > John
> > >
> > > At 09:21 AM 6/15/2010, Marc Khouzam wrote:
> > >>
> > >> DOH!
> > >>
> > >> See below
> > >>
> > >> > -----Original Message-----
> > >> > From: cdt-dev-bounces@xxxxxxxxxxx
> > >> > [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Doug Schaefer
> > >> > Sent: Monday, June 14, 2010 9:12 PM
> > >> > To: CDT General developers list.
> > >> > Subject: [cdt-dev] Final build available, tagged and branched
> > >> >
> > >> > Hey gang,
> > >> >
> > >> > The build is finished and I did a quick sanity. Give 
> it a run and see
> > >> > if there's anything seriously wrong with it. We have 
> until tomorrow
> > >> > (Tues) 2 p.m. Eastern (which is why I hate waiting 
> till so late for
> > >> > respins).
> > >> >
> > >> > The build is here:
> > >> > http://download.eclipse.org/tools/cdt/builds/7.0.0/I.I20100614
> > >> > 1710/index.html
> > >> >
> > >> > I have also tagged this as CDT_7_0_0 and created the 
> branch cdt_7_0.
> > >> > If I do need to respin, I can go back and create an 
> emergency branch
> > >> > for the fix. Hopefully not. At any rate, go nuts :).
> > >>
> > >>
> > >> Of course, now is when I can reproduce the deadlock 
> James had found in
> > >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=314447
> > >>
> > >> The good news is that I have the patch.  I have posted it to
> > >> the bug.  Do I commit to HEAD?
> > >>
> > >> Of course the timing must be horrible:
> > >> I have my son's concert _now_ so I have to leave but 
> I'll be back in 2
> > >> hours.
> > >> If no one else had taken care of it, I'll finish this off.
> > >>
> > >> THE FIX IS NOT COMMITTED YET because I wanted a quick 
> review from someone
> > >> and wasn't sure about which branch anymroe
> > >>
> > >> Sorry about all this.
> > >>
> > >> I'm reachable at 514-951-7191
> > >>
> > >> Marc
> > >>
> > >> _______________________________________________
> > >> cdt-dev mailing list
> > >> cdt-dev@xxxxxxxxxxx
> > >> https://dev.eclipse.org/mailman/listinfo/cdt-dev
> > >
> > >
> > > _______________________________________________
> > > cdt-dev mailing list
> > > cdt-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> > >
> >_______________________________________________
> >cdt-dev mailing list
> >cdt-dev@xxxxxxxxxxx
> >https://dev.eclipse.org/mailman/listinfo/cdt-dev
> 
> 
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>