RE: [cdt-dev] FYI, merged in a bunch of changes

[Chris Recoskie <recoskie@xxxxxxxxxx>]

I have created https://bugs.eclipse.org/bugs/show_bug.cgi?id=312805 and attached an improved patch to it. Please have a look and let me know what you think.

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto

"Schorn, Markus" ---05/12/2010 05:03:58 AM---Hi Chris. I am quite unhappy with this checkin:

From:	"Schorn, Markus" <Markus.Schorn@xxxxxxxxxxxxx>
To:	"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date:	05/12/2010 05:03 AM
Subject:	RE: [cdt-dev] FYI, merged in a bunch of changes
Sent by:	cdt-dev-bounces@xxxxxxxxxxx

---

Hi Chris.
I am quite unhappy with this checkin:
* It introduces new API after API freeze without a heads-up even without a bugzilla!
* It combines multiple changes into one commit without pointing out to what sort of bug the change relates to. 
 
The change related to TranslationUnit is not correct (causes NPEs), I have undone it (see my attachment). 
Please go through the regular process of creating a bug and proposing a solution. 
 
Markus.

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Chris Recoskie
Sent: Wednesday, May 12, 2010 12:55 AM
To: CDT General developers list.
Subject: [cdt-dev] FYI, merged in a bunch of changes
Importance: Low

- Merged changes from cdt_5_0 to HEAD. Too many to mention individually.
- Reworked IFileSystem utility so that now it is noimplement/noextend. Clients should now extend from concrete class FileSystemUtility instead to better insulate them from future API changes.
- Reworked the resulting concurrency fixes - indexing and scanner discovery now synchronize on the project root as a scheduling rule. Original HEAD behaviour was to synch on the project's .settings folder for indexing, but that deadlocked with scanner discovery. James, you will probably want to take a look at what I did there and make sure you are comfortable with it, as I know you have been trying to relax the scheduling rules as much as possible. If you think it needs some rework let me know.
- Fixed remote indexing. Changes on HEAD that deprecated CodeReader broke the ability for remote translation units to provide the path to load the file content from. Added API to ITranslationUnit for this purpose.

The tests all pass, but let me know if you run into any problems, particularly if you encounter any concurrency issues.

FYI error parsing seems broken for remote projects. I intend to start looking into that tomorrow.

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto[attachment "undone.txt" deleted by Chris Recoskie/Toronto/IBM] _______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev