[cdt-dev] API-breaking changes in org.eclipse.cdt.dsf.gdb

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

Hi,

 

I've added a CommandFactory for MI/CLI commands to DSF-GDB (http://bugs.eclipse.org/304146).

Below are some breaking API changes.

 

The last 3 could be made non-breaking by keeping the old constructors and just deprecating it.

I would prefer to remove those constructors to keep things clean.  The plugin has already moved from 2.1 to 3.0 for this release.

 

I've updated http://wiki.eclipse.org/CDT/planning/7.0#API_Changes with these changes.

 

Anyone objects to those changes?

 

1-

The interface IGDBControl used to be defined as
  public interface IGDBControl extends ICommandControlService
but has changed to
  public interface IGDBControl extends IMICommandControl (where IMICommandControl extends ICommandControlService)

This change adds a new method to IGDBControl from IMICommandControl.

I was wondering if there should be an @since tag for that change?  The API Tooling did not request one.

 

2-
GDBControl_7_0 constructor has changed from
  public GDBControl_7_0(DsfSession, ILaunchConfiguration)
to
  public GDBControl_7_0(DsfSession, ILaunchConfiguration, CommandFactory)

3-
AbstractMIControl constructor has changed from
  public AbstractMIControl(DsfSession, boolean)
to
  public AbstractMIControl(DsfSession session, boolean, CommandFactory)

4-
GDBControl constructor has changed from
  public GDBControl(DsfSession, ILaunchConfiguration)
to
  public GDBControl(DsfSession, ILaunchConfiguration, CommandFactory)

Thanks

 

Marc