Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] DSF Register/Variable/Expression Views

All of the DSF bugs related to CDI feature parity have a "[cdi]" string in their summary.  There's also an umbrella bug (237560), for CDI-parity variable view enhancements.  But neither of the issues below is covered by them.

It would make sense to enable the "Change Value..." action, although if I remember correctly there was some technical issue with doing this.  If you can supply a patch, we'll gladly apply it :-)

enable/disable is more complicated.  The problem is (just like with global variables) that we'd need to make a mechanism for storing which variables are enabled/disabled.  In the last CDT summit, we talked about this feature and decided that the update policies for variables which are available for DSF-based views should be enough to satisfy the use cases for the enable/disable feature.


Mehregani, Navid wrote:

Sure, that sounds good.  Do you have the Bugzilla number by any chance?


From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Rohrbach, Randy
Sent: Friday, August 21, 2009 3:38 PM
To: CDT General developers list.
Cc: Rohrbach Randy
Subject: RE: [cdt-dev] DSF Register/Variable/_expression_ Views




    We simply never looked in to doing this. There exist DSF bugzillas which reflect these deficiencies. If you want

    to implement these and supply a patch I will be glad to take a look at the patch and get it in when we can.


    As opposed to creating custom VMCs I would take the above route.




From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Mehregani, Navid
Sent: Friday, August 21, 2009 12:47 PM
To: cdt-dev@xxxxxxxxxxx
Subject: [cdt-dev] DSF Register/Variable/_expression_ Views



I had a simple question about the DSF Register/Variable/_expression_ views that I was hoping someone could help me out with.  I’ve noticed that the ‘Change Value’ context menu action is disabled in all three views.  The reason being is that the default implementation of RegisterVMNode$RegisterVMC and VariableVMNode$VariableExpressionVMC don’t implement IValueModification.  See org.eclipse.debug.internal.ui.actions.variables.ChangeVariableValueAction.update() for more details.


Is there a plan to modify RegisterVMC and VariableExpressionVMC to implement this interface or should I implement a custom version of these VMCs that implement IValueModification?


On a similar note, the ‘Enable’ and ‘Disable’ context menu actions are always disabled because  RegisterVMC and VariableExpressionVMC are not adaptable to IEnableDisableTarget.  See org.eclipse.cdt.debug.internal.ui.actions.EnableVariablesActionDelegate.selectionChanged() for more details.



Thanks in advance,

 - Navid

_______________________________________________ cdt-dev mailing list cdt-dev@xxxxxxxxxxx

Back to the top