[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cdt-dev] Coding horror
|
Chris Recoskie wrote:
Well looking at the blame annotation, that code was last touched in 2006,
and I'm pretty sure that whomever wrote it isn't around any more.
If this is getting in your way so much, I would suggest you post a patch.
Should I report a bug on this to attach the patch to? There are lots of
other places which probably would need a similar treatment, but I might
need a little help on knowing how and what to log.
--
/Jesper
### Eclipse Workspace Patch 1.0
#P org.eclipse.cdt.managedbuilder.core
Index: src/org/eclipse/cdt/managedbuilder/internal/core/Option.java
===================================================================
RCS file: /cvsroot/tools/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/Option.java,v
retrieving revision 1.38
diff -u -r1.38 Option.java
--- src/org/eclipse/cdt/managedbuilder/internal/core/Option.java 11 Jun 2008 15:48:36 -0000 1.38
+++ src/org/eclipse/cdt/managedbuilder/internal/core/Option.java 5 May 2009 09:04:19 -0000
@@ -34,12 +34,15 @@
import org.eclipse.cdt.managedbuilder.core.ITool;
import org.eclipse.cdt.managedbuilder.core.IToolChain;
import org.eclipse.cdt.managedbuilder.core.ManagedBuildManager;
+import org.eclipse.cdt.managedbuilder.core.ManagedBuilderCorePlugin;
import org.eclipse.cdt.managedbuilder.core.ManagedOptionValueHandler;
import org.eclipse.cdt.managedbuilder.core.OptionStringValue;
import org.eclipse.cdt.managedbuilder.internal.enablement.OptionEnablementExpression;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IConfigurationElement;
+import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.PluginVersionIdentifier;
+import org.eclipse.core.runtime.Status;
public class Option extends BuildObject implements IOption, IBuildPropertiesRestriction {
// Static default return values
@@ -1027,6 +1030,9 @@
applicabilityCalculator = (IOptionApplicability) applicabilityCalculatorElement
.createExecutableExtension(APPLICABILITY_CALCULATOR);
} catch (CoreException e) {
+ ManagedBuilderCorePlugin.log(new Status(IStatus.ERROR,
+ ManagedBuilderCorePlugin.getUniqueIdentifier(),
+ IStatus.OK, "Failed to create custom applicability calculator.", e));
}
}
else if(superClass != null)
