[cdt-dev] Please help to review these patches and bugs.

[cdt-dev] Please help to review these patches and bugs.

From: "Zhang, Yi Y" <yi.y.zhang@xxxxxxxxx>
Date: Tue, 4 Nov 2008 19:13:35 +0800
Accept-language: en-US
Acceptlanguage: en-US
Delivered-to: cdt-dev@xxxxxxxxxxx
List-archive: <https://dev.eclipse.org/mailman/private/cdt-dev>
List-help: <mailto:cdt-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/cdt-dev>, <mailto:cdt-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/listinfo/cdt-dev>, <mailto:cdt-dev-request@eclipse.org?subject=unsubscribe>
Thread-index: Ack+bmFIlzDZnLwtTbixECc+yhwUOw==
Thread-topic: Please help to review these patches and bugs.

Hi,

I had made patches for the bugs shown below. Would someone please help to review them?

Bug 231272 - Discovered Includes/Macros disappear after close and open of project.

Bug 241072 - Make options, enclosed by needed Double Quotes, are executed without the Double Quotes.

And I had also examined some other bugs:

Bug 242227 - "remember my decision" doesn't remember. Errors in project continue launch.

I think this bug should be marked as “INVIDE”. I had posted comments on bugzilla, please help to review it.

Bug 222738 - CExternalSettingProvider explicitly undefines variables when removed.

Bug 230029 - Referenced projects should build in foreground if main build is also foreground.

For Bug 222738 and Bug 230029, I had examined them and found the problems of these two bugs were solved. So please help to review and close them.

Thanks,

Follow-Ups:
- Re: [cdt-dev] Please help to review these patches and bugs.
  - From: Elena Laskavaia