RE: [cdt-dev] Warnings and SuppressWarnings

["Schorn, Markus" <Markus.Schorn@xxxxxxxxxxxxx>]

no-one objected, I'll turn the warning off.

Markus.

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Sergey Prigogin
Sent: Monday, April 14, 2008 5:28 AM
To: CDT General developers list.
Subject: Re: [cdt-dev] Warnings and SuppressWarnings
Importance: Low

A warning for unnecessary 'else' statement seems excessive. Does anybody object to turning it off?

-sergey

On Wed, Apr 9, 2008 at 4:39 AM, Schorn, Markus <Markus.Schorn@xxxxxxxxxxxxx> wrote:

I have increased the warning level (including all of Mike's suggestions)
for the ui-plugin and applied the same settings to the core plugin.

There are a lot of warnings now, I have started to fix warnings (for now
in the ui-plugin) and hope to get some help from some you.

Markus.

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Mike Kucera

> Sent: Tuesday, April 08, 2008 4:27 PM
> To: CDT General developers list.

> Subject: RE: [cdt-dev] Warnings and SuppressWarnings
> Importance: Low
>
> I would never veto something that people clearly want.
>
> May I make a few more suggestions (based on the current
> settings in the UI
> plugin) :
>
> redundant null check -> warning
> unnecessary else statement -> warning
> redundant super interface -> warning
> usage of raw type -> warning
> missing @override annotation -> warning
> missing @deprecated annotation -> warning unused import -> error
>
>
> Mike Kucera
> Software Developer
> IBM CDT Team, Toronto
> mkucera@xxxxxxxxxx
>
>
>
>
>              "Schorn, Markus"
>
>              <Markus.Schorn@wi
>
>              ndriver.com>
>           To
>              Sent by:                  "CDT General
> developers list."
>              cdt-dev-bounces@e         <cdt-dev@xxxxxxxxxxx>
>
>              clipse.org
>           cc
>
>
>
>      Subject
>              04/08/2008 04:56          RE: [cdt-dev] Warnings
> and
>              AM                        SuppressWarnings
>
>
>
>
>
>              Please respond to
>
>                "CDT General
>
>              developers list."
>
>              <cdt-dev@eclipse.
>
>                    org>
>
>
>
>
>
>
>
>
>
> Ok, I'd like to increase the warning levels:
> "Enum type constant not covered on switch":  none -> warning
> "Null pointer access":                       warning -> error
> "Potential null pointer access":             none -> warning
> "switch case fall-through":
> none -> warning
>
> Please reply, if you have an objection.
>
>
> Mike, if you don't explicitly veto this, I'll enable the
> shared warning-settings for the core-plugin, also.
>
> Markus.
>
>
> > -----Original Message-----
> > From: cdt-dev-bounces@xxxxxxxxxxx
> > [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Mike Kucera
> > Sent: Tuesday, April 08, 2008 1:59 AM
> > To: CDT General developers list.
> > Subject: Re: [cdt-dev] Warnings and SuppressWarnings
> > Importance: Low
> >
> > +1
> >
> > I like the idea of turning some warnings into errors.
> >
> > Mike Kucera
> > Software Developer
> > IBM CDT Team, Toronto
> > mkucera@xxxxxxxxxx
> >
> >
> >
> >
> >              Elena Laskavaia
> >
> >              <ELaskavaia@qnx.c
> >
> >              om>
> >           To
> >              Sent by:                  "CDT General
> > developers list."
> >              cdt-dev-bounces@e         <cdt-dev@xxxxxxxxxxx>
> >
> >              clipse.org
> >           cc
> >
> >
> >
> >      Subject
> >              04/07/2008 12:38          Re: [cdt-dev] Warnings
> > and
> >              PM                        SuppressWarnings
> >
> >
> >
> >
> >
> >              Please respond to
> >
> >                "CDT General
> >
> >              developers list."
> >
> >              <cdt-dev@eclipse.
> >
> >                    org>
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > I think it is good idea. But we should enable as much as we can and
> > turn some warning into errors, such as unused import.
> >
> > Schorn, Markus wrote:
> > >
> > > Hi,
> > > I am getting a bunch of warnings in the core-plugin of
> the following
> > > kind: Unnecessary @SuppressWarnings. I assume this is because my
> > > compiler warning settings differ from the ones of others.
> > >
> > > Therefore I suggest to use a common set of warnings for all
> > of us and
> > > check it into CVS (like we are doing this in the cdt.ui plugin).
> > >
> > > Has anyone objections against this? I'd start out with the same
> > > settings as we are using for the ui-plugin.
> > >
> > > Markus.
> > > _______________________________________________
> > > cdt-dev mailing list
> > > cdt-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> > >
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >
> >
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev