Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [cdt-dev] Managed Build Bug?



I have just looked through the GnuMakefileGenerator code in order to understand how the libs and objects are handled while generating the gnu makefile, and I noticed that libs and objects specified in the tool options are treated in the special way there. The LIBRARIES and OBJECTS option values are currently treated as the “tool inputs”, while other option values are treated as “tool commands” for the Command Line Generator (see org.eclipse.cdt.managedbuilder.core.IManagedCommandLineGenerator). On the other hand, the UI code used to obtain and display the tool flags treats LIBRARIES and OBJECTS options as all other option types (as tool commands). I suppose that we might leave the logic as it is for now and fix the comments for the ITool.getToolCommandFlags() to bring the clarity into this and also fix the UI code.

In your case I suppose that you should modify the NMakeMakefileGenerator in order to make the tool inputs be correctly obtained and added to the buildfile.

You could use IManagedBuildInfo.getLibsForConfiguration() and IManagedBuildInfo.getUserObjectsForConfiguration() in order to obtain user-specified libraries and objects respectively.





From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Emiliano Lesende
Sent: Tuesday, June 21, 2005 6:56 PM
To: CDT General developers list.
Subject: Re: [cdt-dev] Managed Build Bug?


Would you be so kind to generate an integration build after you corrected the bug?


Thank you very much



On 6/21/05, Sennikovsky, Mikhail <mikhail.sennikovsky@xxxxxxxxx> wrote:

Hi Emiliano,


It is really strange for me why the LIBRARIES options are not handled in the Tool.getToolCommandFlags (). I have also noticed that the IOption.OBJECTS options are not handled there also. This is definitely a bug and I'm going to fix this. Thanks for finding and reporting the problem.





From: cdt-dev-bounces@xxxxxxxxxxx [mailto: cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Emiliano Lesende
Sent: Tuesday, June 21, 2005 7:09 AM
To: CDT General developers list.
Subject: [cdt-dev] Managed Build Bug?


I was testing today my own toolchain when I came across something really weird. I added a few library paths to the linker and when the makefile generator builded the makefile they didn't showed up. After careful browsing of source code and debugging, I came to realize that my toolchain defined the library inputs as "libs" type, not stringList.

Then the generator called the getToolCommandFlags on the Tool class to populate command arguments for the linker, but that method contains a case switch that doesn't contain IOption.LIBRARIES, so they will never get returned.

Am I doing something wrong? Or is it really a bug?


cdt-dev mailing list


Back to the top