Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [cdt-dev] New code: IOptionApplicability - Merge conflict

> I didn’t see anything in your proposal for the shared tool options about an IHoldsOptions ...
That is correct. I discussed with Leo last week whether to replicate a lot of the functionality which is implemented in ITool for holding options also in IToolChain or whether to move it down to an interface, IHoldsOptions, which Tool and ToolChain implements.
  • public interface ITool extends IBuildObject, IHoldsOptions {
  • public interface IToolChain extends IBuildObject, IHoldsOptions {
  • public class Tool extends HoldsOptions implements ITool, IOptionCategory {
  • public class ToolChain extends HoldsOptions implements IToolChain {

> ITool extend IHoldsOptons
That's what I have done. But the signature of the call-backs is not generic enough, i.e. if the code is to work in all situatiuons the first argument has to be of a different type.

-- Lars

"Recoskie, Chris" <crecoskie@xxxxxx>
Sent by: cdt-dev-bounces@xxxxxxxxxxx

31/05/2005 20:21

Please respond to
"CDT General developers list." <cdt-dev@xxxxxxxxxxx>

"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
RE: [cdt-dev] New code: IOptionApplicability - Merge conflict

I didn’t see anything in your proposal for the shared tool options about an IHoldsOptions interface, so forgive me for shooting in the dark, but can you not just have ITool extend IHoldsOptons?
Chris Recoskie
Software Designer
IDE Frameworks Group
Texas Instruments, Toronto

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Lars.Kurth@xxxxxxxxxxx
Tuesday, May 31, 2005 3:00 PM
CDT General developers list.
[cdt-dev] New code: IOptionApplicability - Merge conflict



I am trying to merge the latest changes from CDT-build such that I can prepare a patch for CDT tomorrow. The following newly introduced code is causing difficulties:
  • IOptionApplicability has methods, which use ITool as parent for an option
  • We have moved all functionality which was in ITool and had to do with the capability of holding options into a common interface IHoldsOptions
  • I have a real merge conflict with the function IOptionApplicability.isOptionEnabled() which would have to have the type IHoldsOptions
  • For the other members of IOptionApplicability this would probably be necessary as well
How would this be resolved?

-- Lars

********************************************************************** Symbian Software Ltd is a company registered in England and Wales with registered number 4190020 and registered office at 2-6 Boundary Row, Southwark, London, SE1 8HP, UK. This message is intended only for use by the named addressee and may contain privileged and/or confidential information. If you are not the named addressee you should not disseminate, copy or take any action in reliance on it. If you have received this message in error please notify postmaster@xxxxxxxxxxx and delete the message and any attachments accompanying it immediately. Neither Symbian nor any of its subsidiaries accepts liability for any corruption, interception, amendment, tampering or viruses occurring to this message in transit or for any message sent by its employees which is not in compliance with Symbian corporate policy. ********************************************************************** _______________________________________________
cdt-dev mailing list

Back to the top