RE: [cdt-debug-dev] [Bug 104421] Register view can not showcorrec tvalue

[Alain Magloire <alain@xxxxxxx>]

The new interface would look like this:

ICDIGlobalVariable
ICDITarget.createGLobalVariable(ICDIGlobalVariableDescritptor desc);

ICDIThreadLocalVariable
ICDIThread.createThreadLocalVariable(ICDIThreadLocalVariableDescriptor
desc);

ICDILocalVariable
ICDIStackFrame.createLocalVariable(ICDILocalVariableDescriptor desc);

ICDIRegister
ICDIStackFrame.createRegister(ICDIRegisterDescriptor desc);

In this version, we provided the method factory on the object that can
create them.  In the old interface:

IVariableDescritor.createVariable(); // Wrong! to be removed

The method factory was not on the correct class.  Things broke for registers
since they were created on the Target(ICDITarget) but needed a context
(stackframe) for the evaluation, the debugger backend may provide different
values depending on the context for example, the pc ($eip) comes to mind as
a register with different value depending on the context.

> -----Original Message-----
> From: cdt-debug-dev-bounces@xxxxxxxxxxx [mailto:cdt-debug-dev-
> bounces@xxxxxxxxxxx] On Behalf Of Sebastien Marineau
> Sent: Tuesday, July 26, 2005 4:22 PM
> To: CDT Debug developers list
> Subject: RE: [cdt-debug-dev] [Bug 104421] Register view can not showcorrec
> tvalue when switch between different thread or stack frame
> 
> Unfortunately, this may be more complicated. From the conversation
> yesterday
> on the call and Mikhail's comment below, it looks like the fix will
> require
> a change to CDI. While I have no doubt this can be fixed by end of year,
> I'm
> not sure breaking the CDI interfaces in a minor release is really
> appropriate.
> 
> Here's a couple of thoughts:
> 
> 1. how long would it actually take to implement the "right" solution
> including the CDI change (plus implementation)? Can we make a go/no-go
> decision based on this?
> 2. would it be possible (if we don't do #1) to make the adjustments to CDI
> (e.g. update the interfaces) so that we don't have to break them when
> fixing
> this issue -- we add "getRegisterGroups" to "ICDIStackFrame" for 3.0 while
> "getRegisterGroups" in "ICDITarget" becomes deprecated with our next
> release.
> 3. In any case, we should definitely include this in a 3.0.1 pure bugfix
> release (as opposed to 3.1 with some features).
> 
> Sebastien
> 
> > -----Original Message-----
> > From: cdt-debug-dev-bounces@xxxxxxxxxxx
> > [mailto:cdt-debug-dev-bounces@xxxxxxxxxxx] On Behalf Of
> > Recoskie, Chris
> > Sent: Tuesday, July 26, 2005 3:58 PM
> > To: CDT Debug developers list
> > Subject: RE: [cdt-debug-dev] [Bug 104421] Register view can
> > not showcorrectvalue when switch between different thread or
> > stack frame
> >
> > Hmm.
> >
> > That sounds far too big for this late for 3.0.
> >
> > On the other side of things though...
> > AAAAAAAAAAAAAAAAAAAAAAAAAAAAARGH!
> >
> > Shooting from the hip, from our POV we would need to have
> > this fixed by the end of the year, and would have to do it
> > ourselves if required.  Who wants to start drafting the plan
> > for 3.1?  :-)
> >
> > ___________________________________________
> >
> > Chris Recoskie
> > Software Designer
> > IDE Frameworks Group
> > Texas Instruments, Toronto
> >
> >
> >
> > > -----Original Message-----
> > > From: cdt-debug-dev-bounces@xxxxxxxxxxx [mailto:cdt-debug-dev-
> > > bounces@xxxxxxxxxxx] On Behalf Of Mikhail Khodjaiants
> > > Sent: Tuesday, July 26, 2005 3:45 PM
> > > To: CDT Debug developers list
> > > Subject: Re: [cdt-debug-dev] [Bug 104421] Register view can not
> > > showcorrectvalue when switch between different thread or stack frame
> > >
> > > The "getRegisterGroups" has to be moved from "ICDITarget" to
> > > "ICDIStackFrame". Plus, the entire implementation of the
> > register-related
> > > classes has to be modified to fit in this new model.
> > >
> > > ----- Original Message -----
> > > From: "Recoskie, Chris" <crecoskie@xxxxxx>
> > > To: "CDT Debug developers list" <cdt-debug-dev@xxxxxxxxxxx>
> > > Sent: Tuesday, July 26, 2005 3:34 PM
> > > Subject: RE: [cdt-debug-dev] [Bug 104421] Register view can
> > not show
> > > correctvalue when switch between different thread or stack frame
> > >
> > >
> > > > Ugh...  viewing the registers as you walk the stack is a
> > pretty core
> > > > thing to do for us.  Can you detail roughly what would have to
> > change?
> > > >
> > > >
> > > >
> > > > ___________________________________________
> > > >
> > > >
> > > >
> > > > Chris Recoskie
> > > >
> > > > Software Designer
> > > >
> > > > IDE Frameworks Group
> > > >
> > > > Texas Instruments, Toronto
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >  _____
> > > >
> > > > From: cdt-debug-dev-bounces@xxxxxxxxxxx
> > > > [mailto:cdt-debug-dev-bounces@xxxxxxxxxxx] On Behalf Of Mikhail
> > > > Khodjaiants
> > > > Sent: Tuesday, July 26, 2005 3:21 PM
> > > > To: cdt-debug-dev@xxxxxxxxxxx; cdt-dev@xxxxxxxxxxx
> > > > Subject: [cdt-debug-dev] [Bug 104421] Register view can not show
> > > > correctvalue when switch between different thread or stack frame
> > > >
> > > >
> > > >
> > > > Hi,
> > > >
> > > >
> > > >
> > > > Alain and I have investigated several solutions for this
> > problem and
> > > > have come to conclusion that serious changes (in the CDI interface
> > and
> > > > the core implementation) are needed to fix it.
> > > >
> > > > The problem is serious and the only workaround is to view the
> > correct
> > > > value in the detail pane of the Registers view.
> > Nevertheless, we are
> > > > suggesting to defer it.
> > > >
> > > > Comments? Suggestions?
> > > >
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Mikhail Khodjaiants
> > > >
> > > >
> > >
> > > _______________________________________________
> > > cdt-debug-dev mailing list
> > > cdt-debug-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/cdt-debug-dev
> > _______________________________________________
> > cdt-debug-dev mailing list
> > cdt-debug-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/cdt-debug-dev
> >
> _______________________________________________
> cdt-debug-dev mailing list
> cdt-debug-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-debug-dev