[cdt-debug-dev] Re: [cdt-dev] Proposed modifications to CDT for 64-bit s

["Alain Magloire" <alain@xxxxxxx>]

> 
> Hi All,
> 
> I have entered a proposal for CDT to enable 64-bit application
> development/debugging.
> 
> Please see https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D69908 for =
> more
> details.=20
> 
> I would like to discuss this proposal so this or similar solution will
> be adopted by future CDT release.=20

It looks great, commited to 

  cdt-core-home/docs

Some initial reactions:

	- CDT assumes that long is 32bit length however it is 64 bit
	length on Linux 64bit platforms and 32 bit length on Windows 64bit platform

 * Is not "long" define to be 32 bits in ANSI C ?  or did you mean "int"

- In the interface IAddress
	IAddress add (BigInteger offset);
 * is "IAddress add(IAddress addr);" missing ? or volountary left out  

- extends comparable
 	int compareTo(..);
 * make the interface extends java.lang.comparable, also.

- format
	String toSring(int radix)
	String toHexAddressString();
 * is toString(16) equivalent to toHexAddressString() ? if yes toHexAddressString() seems superfluous.

- Address Factory
  Why the need for an address factory class why not move the createAddress() in
  the Addr32/addr64 classes as static methods.

- Elf64 vs Elf32
  writing an Elf64 class(and renaming Elf to Elf32) may turn out to be easier then changing the Elf
  class directly ... but ...