Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-core-dev] ICElement line number

I would like to see those CElement methods delegating to an 
ILineOffsetReconciler for those calls. 

JohnC

cdt-core-dev-admin@xxxxxxxxxxx wrote on 08/22/2003 01:20:49 PM:

> 
> Hi, 
> I think the CEditor relies on offsets, which will be provided by the 
parser. 
> There will be another mechanism to convert from offsets to line 
> numbers for other modules to use. So It will be provided but only 
> when needed and not with every call to parse. 
> Maybe JohnC could elaborate some more on the effect on performance. 
> 
> Regards, 
> Hoda Amer
> Staff Software Engineer
> Rational Software - IBM Software Group 
> 
> 

> 
> "Alain Magloire" <alain@xxxxxxx> 
> Sent by: cdt-core-dev-admin@xxxxxxxxxxx 
> 08/22/2003 11:59 AM 
> Please respond to cdt-core-dev 
> 
> 
>         To:        cdt-core-dev@xxxxxxxxxxx 
>         cc: 
>         Subject:        [cdt-core-dev] ICElement line number
> 
> 
> 
> 
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=36379
> > 
> > hamer@xxxxxxxxxx changed:
> > 
> >            What    |Removed                     |Added
> > 
----------------------------------------------------------------------------
> >                  CC|                            |jcamelon@xxxxxxxxxx
> >              Status|NEW                         |RESOLVED
> >          Resolution|                            |FIXED
> > 
> > 
> > 
> > ------- Additional Comments From hamer@xxxxxxxxxx  2003-08-22 11:01 
-------
> > It has been decided that line numbers would not be provided by the 
parser
> > while parsing to build CModel Elements for performance reasons.
> > 
> > Question: Should we remove fStartLine and fEndLine from CElement?
> > 
> 
> 
> This is quite major.  For example The CEditor uses this for selected 
elements
> it allows to edit only a region,  This is very practical when 
> editing large files.
> 
> Also other modules rely on this.
> 
> I can not comment on the "performance reasons" did not follow the code.
> But see lot of implications of not having this.
> 
> 
> _______________________________________________
> cdt-core-dev mailing list
> cdt-core-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-core-dev



Back to the top