Re: [cdi-dev] Assumption that WAR can contain SE service files (for CDI

[Matej Novotny <manovotn@xxxxxxxxxx>]

The issue you linked is about reading the service file from WAR regardless of whether it is supposed to be a BDA or not.

And this is done by many more existing TCKs which I assume you pass just fine (here is an example https://github.com/jakartaee/cdi-tck/blob/master/impl/src/main/java/org/jboss/cdi/tck/tests/full/extensions/lifecycle/bbd/BeforeBeanDiscoveryTest.java).

However, the three tests you noted here are probably the only tests in TCK that enforce the situation where there is a legitimate extension but the archive itself is not a BDA.

So I'd say the cause for these test failures is elsewhere?

In short, I'm not sure it's defined anywhere that a Servlet container should be able to load SE service files from "WEB-INF/classes/META-INF/services", as the spec only ever talks about jars in WEB-INF/lib.

I am not sure how defined this is but the TCKs have had many tests with this structure for years and all all EE servers seemed to have passed them.

Matej

On Mon, May 23, 2022 at 5:00 PM arjan tijms <arjan.tijms@xxxxxxxxx> wrote:

Hi,

On Mon, May 23, 2022 at 4:39 PM Ladislav Thon <lthon@xxxxxxxxxx> wrote:

This basically means that if WEB-INF/classes were zipped up into a JAR and put into WEB-INF/lib, nothing would change.

Is that a bad intuition?

I would sometimes want it to work like that indeed, and it always has been surprising in a way it doesn't work like that. On the other hand, the .war is more than just  WEB-INF/classes, it's all the other things in the war file too (other files in WEB-INF/ and the root of course).

Right now archive inspectors (like the one in GF) inspect the archives, and treat the WEB-INF/lib entries as embedded archives, but not WEB-INF/classes.

Kind regards,

Arjan Tijms

_______________________________________________
cdi-dev mailing list
cdi-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdi-dev