Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ca-dev] [External] : Notnull and Nullable annotations on the Jakarta Annotation spec
  • From: Lukas Jungmann <lukas.jungmann@xxxxxxxxxx>
  • Date: Mon, 25 Apr 2022 17:21:06 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EtUutSK9YJs9GH4mhAlujU7HcgS8h1h/nQBBvfAOkRE=; b=TBKa/6vM8XY8maitc6syNsRuQkywnJEqtkfmLwLhrtuXlg4Q10PrktfrIFpU4vzVmUltBIr0pGK7x4aDaC5mnqQhxI4sJzn0cTpoVhoIPTeAwQLzck4gMmAU31MLUcMg7CpSaOwSGUtOE2yt3rx0heWvsbxvUVtvehJjtscxzojbCJJs1Xm800vUN11C0EoNoes9qhxXNUvUVmAFXYDZPRhEqgepR5diQFqAMIH3YRan/isGxvI1w2eZsUci1e5YMiVzW83aEI+5Uf6zVrWE+R1uwz1cQKlpQCFR8mnFuRaw6KYoNeCTDTJSQGqVskETS8cnFuJhVbtcRMW/8aTbug==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EfOs7Uct8/re7TbAFbUvT64ZQbzcL8HfKAiNKj+liSZGbghuYKM6eeimOLWZjwKevMyAtpN8+CcQTbk7ZYJfYAG+RPRiZ8pAo6c5X79oSgm0idZ+YQ5mrlheHBi7aOUnywSaWvCP9WkNsa/YloJmd8rmegFGXEAOY9RsFaJx5LYO2AqQD8hE9qK4/wrmC2vlVjcoGlWV7m+uBmNIEOdQNo3RCbuh0XA6sCIZgKuNxVZLDZPY9P+QL+diKhoChDJJ1jukDJNK199TwoT5F+cfk7cYKk63bsjNmV/eQvKvUMD4bq3SrEmif5UpRwOgDYwbp98CD36out4w+o1lac5BIg==
  • Delivered-to: ca-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/ca-dev/>
  • List-help: <mailto:ca-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/ca-dev>, <mailto:ca-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/ca-dev>, <mailto:ca-dev-request@eclipse.org?subject=unsubscribe>
  • User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1

On 4/25/22 4:12 PM, Emily Jiang via ca-dev wrote:
Thank you Lukas!
The annotation is not only for static analysis but also for runtime as stated here https://github.com/eclipse-ee4j/common-annotations-api/blob/master/spec/src/main/asciidoc/spec.adoc#jakartaannotationnonnull <https://urldefense.com/v3/__https://github.com/eclipse-ee4j/common-annotations-api/blob/master/spec/src/main/asciidoc/spec.adoc*jakartaannotationnonnull__;Iw!!ACWV5N9M2RV99hQ!MiTOoQKpccM6OIFgwvftvJWVPw93GGeIZyu-jekS98JL9YJ9O6O8MpjtgKJJkUea97EcsIoWhryp1nHaKNc$> For the runtime bit, I think we need to ensure implementors implement this. Right?

If my Awesome Spec decides to define usage if this annotation, it should have the TCK to verify the behavior. Or are you trying to say that the Annotations TCK has to have a test to verify the behavior of the @Priority?

thanks,
--lukas


Thanks
Emily

On Mon, Apr 25, 2022 at 12:33 PM Lukas Jungmann <lukas.jungmann@xxxxxxxxxx <mailto:lukas.jungmann@xxxxxxxxxx>> wrote:

    On 4/25/22 1:02 PM, Emily Jiang via ca-dev wrote:
     > In Jakarta Common Annotations 2.1, the annotation @Notnull and
    @Nullable
     > were added to the specification via the issue 90
     >
    <https://urldefense.com/v3/__https://github.com/eclipse-ee4j/common-annotations-api/pull/90/files__;!!ACWV5N9M2RV99hQ!NpP1EQQdUk20hOCJBPJOkqQ0WzPCXRCKCInrRfXh_1lBuDSViSvWRWc0CWe_EmAEr73KmttuljI_pOuua3A$
    <https://urldefense.com/v3/__https://github.com/eclipse-ee4j/common-annotations-api/pull/90/files__;!!ACWV5N9M2RV99hQ!NpP1EQQdUk20hOCJBPJOkqQ0WzPCXRCKCInrRfXh_1lBuDSViSvWRWc0CWe_EmAEr73KmttuljI_pOuua3A$>>.

     >
     >
     > Normally for other annotations defined in Jakarta Common
    Annotations,
     > the implementations were provided by other specifications.

    I do not think the statement applies to @Generated (which is similar to
    if not the same as javax.annotation.processing.Generated).
    @Notnull/@Nullable are in the same group - they may be useful to static
    analysis tools and to improve code readability

       For the above
     > new annotations, does it mean the implementation for common
    annotations
     > needs to provide the implementation as I was not sure which
     > specifications pull in these annotations? Does anyone know where the
     > TCKs are for validating the implementation?

    AFAIK there is only signature test available in Jakarta Annotations
    TCK[1]. Should your question be about ie @Priority - take the spec
    which
    defines its usage and check its TCK (can be ie CDI, REST,..)

    thanks,
    --lukas

    [1]:
    https://download.eclipse.org/jakartaee/annotations/2.1/jakarta-annotations-tck-2.1.0.zip
    <https://urldefense.com/v3/__https://download.eclipse.org/jakartaee/annotations/2.1/jakarta-annotations-tck-2.1.0.zip__;!!ACWV5N9M2RV99hQ!MiTOoQKpccM6OIFgwvftvJWVPw93GGeIZyu-jekS98JL9YJ9O6O8MpjtgKJJkUea97EcsIoWhryp6yfuU_U$>
     >
     > --
     > Thanks
     > Emily
     >
     >
     > _______________________________________________
     > ca-dev mailing list
     > ca-dev@xxxxxxxxxxx <mailto:ca-dev@xxxxxxxxxxx>
     > To unsubscribe from this list, visit
    https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/ca-dev__;!!ACWV5N9M2RV99hQ!NpP1EQQdUk20hOCJBPJOkqQ0WzPCXRCKCInrRfXh_1lBuDSViSvWRWc0CWe_EmAEr73KmttuljI_XDZ3jww$
    <https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/ca-dev__;!!ACWV5N9M2RV99hQ!NpP1EQQdUk20hOCJBPJOkqQ0WzPCXRCKCInrRfXh_1lBuDSViSvWRWc0CWe_EmAEr73KmttuljI_XDZ3jww$>

    _______________________________________________
    ca-dev mailing list
    ca-dev@xxxxxxxxxxx <mailto:ca-dev@xxxxxxxxxxx>
    To unsubscribe from this list, visit
    https://www.eclipse.org/mailman/listinfo/ca-dev
    <https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/ca-dev__;!!ACWV5N9M2RV99hQ!MiTOoQKpccM6OIFgwvftvJWVPw93GGeIZyu-jekS98JL9YJ9O6O8MpjtgKJJkUea97EcsIoWhrypN42BF6E$>



--
Thanks
Emily


_______________________________________________
ca-dev mailing list
ca-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/ca-dev__;!!ACWV5N9M2RV99hQ!MiTOoQKpccM6OIFgwvftvJWVPw93GGeIZyu-jekS98JL9YJ9O6O8MpjtgKJJkUea97EcsIoWhrypN42BF6E$



Back to the top