The automatic bug linking only works if you start the first
line of the commit message with Bug 12345 or [12345].
Hi Paul,
so now I finally managed to push my changes into Gerrit (for
the neon branch)
https://git.eclipse.org/r/97015
I fixed also the problem with the missing
DefinitionalCollaborationRef. To me it looks that this will
fix much of the magic effects of breaking collaboration
diagrams when copy/paste Participants.
I tested several ways creating new pools, and everything looks
working fine.
I also manged to figure out the correct way to push to gerrit.
I updated the tutorial:
https://wiki.eclipse.org/BPMN2-Modeler/DeveloperTutorials/HowToStartContributing
The only thing which did not work as expected was that the
gerrit link was not added automatically to the bugzilla issue.
I have added the link manually into the issue
https://bugs.eclipse.org/bugs/show_bug.cgi?id=516607
Maybe my commit message is still wrong?
Please let me know what you think about my code changes and
how/if I should add the changed also into the master branch?
I think we should go through the actually extensive list of
issues in bugzilla to figure out which of the bugs are
outdated. Maybe we can make a kind of vote for closing old
bugs and than we wait and see if anyone screams. What do you
think?
Best regards
Ralph
On 13.05.2017 01:34, Ralph Soika wrote:
Hi Paul,
can you please help me with a problem in the bpmn2 modeler?
We have an old bug concerning copy/paste feature in the
BPMN2 Modeler:
1. create a new collaboration Diagram (the default diagram
will contain two Participants/Pools )
2. next copy (via clipboard) the second participant/pool
3. and paste this new participant/pool into the diagram
4. save the bpmn file.
Now if you look into the xml file, you can see that we have
now 4 participants/pools!
The reason for that behavior is line 394 in class :
'org.eclipse.bpmn2.modeler.core.features.DefaultPasteBPMNElementFeature'
The code there creates a new Process class. From my
perspective (and a lot of debugging) this is in general
correct, because the contained elements must be copied into
a new process!
But the problem now is, that the call to create a new
process:
Process process = Bpmn2ModelerFactory.createObject(resource,
Process.class);
Will again result in the creation of another new
Participant/pool . The reason here is line 112 in the class
'org.eclipse.bpmn2.modeler.ui.adapters.properties.RootElementPropertiesAdapter'
I can not see why the code there should be necessary. If I
skip the else-if block in line 112 everything seems to
works fine.
I have reported the bug : https://bugs.eclipse.org/bugs/show_bug.cgi?id=516607
But as I lost my committer status I was unable to upload my
changes to Gerrit for review.
I know that there is still another problem with the missing
'definitionalCollaborationRef' of the new Participant. I
think I can solve this, but first I wanted to hear you
opinion about this stuff.
Thanks for helping me,
Ralph
--
Imixs...extends
the way people work together
We are an open source company, read more at: www.imixs.org
Imixs Software
Solutions GmbH
Agnes-Pockels-Bogen 1, 80992 München
Web: www.imixs.com
Office: +49 (0)89-452136 16 Mobil:
+49-177-4128245
Registergericht: Amtsgericht Muenchen, HRB 136045
Geschaeftsfuehrer: Gaby Heinle u. Ralph Soika
|
--
Imixs...extends
the way people work together
We are an open source company, read more at: www.imixs.org
Imixs Software
Solutions GmbH
Agnes-Pockels-Bogen 1, 80992 München
Web: www.imixs.com
Office: +49 (0)89-452136 16 Mobil:
+49-177-4128245
Registergericht: Amtsgericht Muenchen, HRB 136045
Geschaeftsfuehrer: Gaby Heinle u. Ralph Soika
|
_______________________________________________
bpmn2-modeler-dev mailing list
bpmn2-modeler-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/bpmn2-modeler-dev
