RE: [birt-dev] API change request: APIchangerequest:AddHyperlinkAction A

["Wenfeng Li" <wli@xxxxxxxxxxx>]

+1 for the 2nd option too.  Do we have tasktype defined already in engine api?

-----Original Message-----
From: "Wei Wang" <wwang@xxxxxxxxxxx>
To: "Wenfeng Li" <wli@xxxxxxxxxxx>; "birt-dev@xxxxxxxxxxx" <birt-dev@xxxxxxxxxxx>
Cc: "Wei Yan" <wyan@xxxxxxxxxxx>
Sent: 3/14/07 8:35 PM
Subject: RE: [birt-dev] API change request: APIchangerequest:AddHyperlinkAction APIs

Should we return an String value or int value for this api?

1.       for String value, the name of the api should be getTaskName()

2.       for int value, the name of the api should be getTaskType()

 

I prefer the 2nd one, as we return a int value is(may be) more useful for client who call it.

 

Waiting for your reply, thanks.

 

Wei Wang

 

________________________________

From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of Wenfeng Li
Sent: Thursday, March 15, 2007 4:17 AM
To: Scott Rosenbaum; birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] API change request: APIchangerequest:AddHyperlinkAction APIs

 

Yes, +1 for having all the tasks for the return value...

 

 

wenfeng

	-----Original Message-----
	From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of Scott Rosenbaum
	Sent: Wednesday, March 14, 2007 1:06 PM
	To: birt-dev@xxxxxxxxxxx
	Subject: RE: [birt-dev] API change request: API changerequest:AddHyperlinkAction APIs

	Interesting when you kick things around, the ideas get better.  It seems appropriate that we use the actual engine task instead of inventing a new concept (mode).  Do we want to have values for all of the engine tasks?

	 - GetParameterDefinition

	- Run

	- Render

	- RunAndRender

	- DataExtraction

	 

	Scott

	 

	________________________________

		From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of Wenfeng Li
	Sent: Wednesday, March 14, 2007 2:47 PM
	To: Wenfeng Li; Wei Wang; birt-dev@xxxxxxxxxxx
	Subject: RE: [birt-dev] API change request: API change request:AddHyperlinkAction APIs

	 

	Wei

	 

	Does a  method getTaskName() work better for this API client's usage?   IT can return RunTask, RednerTask, and RUnandRenderTask...

	 

	Thanks

	 

	wenfeng

		-----Original Message-----
		From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of Wenfeng Li
		Sent: Wednesday, March 14, 2007 12:37 PM
		To: Wei Wang; birt-dev@xxxxxxxxxxx
		Subject: RE: [birt-dev] API change request: API change request: AddHyperlinkAction APIs

		Wei,

		 

		Which mode will be return in RunAndRender Task?  Will the "mode" change between generation and rendiner stage of this task?

		 

		What do you think of replacing these two methods (isInFactory() and IsInPresentation() ) with one method - getProcessingStage() with enum value of generation and rendering?

		 

		Regards,

		 

		Wenfeng

			-----Original Message-----
			From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of Wei Wang
			Sent: Tuesday, March 13, 2007 8:38 PM
			To: birt-dev@xxxxxxxxxxx
			Subject: [birt-dev] API change request: API change request: Add HyperlinkAction APIs

			Add new methods to return the mode of execution.

			Clients have the request to access the whether a report is in factoryMode or presentationMode. 

			 

			For fix bugs:

			131577 --- Script Access to Factory/Presentation Mode