Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [birt-dev] FW: API Change Request for IFileLocator

Title: RE: [birt-dev] FW: API Change Request for IFileLocator



IFileLocator is public API, but no class implements it this moment. So after evaluating this change, I thought it’s just one small enhancement and sent API CR to for community approval. Except the change proposal from Wei Yan, I didn’t receive any feedback, so this change is approved by default according to the process.




Qi Liang



Eclipse development process requires us not to break compatibility for public APIs.  Was IFileLocator a public API? IF so, we can not change its name.  We can add new APIs, however.

Also, we want to avoid API changes or adding new APIs in a point release.  So this API changes probably should wait until after 1.0.1.

If this API was a private API, then we are free to change and there is no need to go thru these API change control doc.



-----Original Message-----
From: birt-dev-bounces@xxxxxxxxxxx on behalf of Qi Liang
Sent: Mon 7/18/2005
7:46 PM
To: birt-dev@xxxxxxxxxxx
Subject: [birt-dev] FW: API Change Request for IFileLocator


Wei's suggestion is accepted. IFileLocator will be renamed to
IResourceLocator and the corresponding method is renamed from "File" to
"Resource". The updated Change Request is attached, and change will be
performed today.


Qi Liang

-----Original Message-----
From: Wei Yan
Friday, July 15, 2005 1:48 PM
To: Qi Liang; #Birt Development
Subject: RE: API Change Request for IFileLocator

That's fine for file based storage. If you consider about other storage
such as archives (JAR/ZIP), it has some limitations.


1)    change the name from IFileLocator to IResourceLocator

2)    change the API findFile to:

URL findResource(ReportDesignHandle designHandle, String resourceName,
int type)

Here it returns a URL instead of a String, the user can use
URL.openStream to get the resource content. It is possible for us to
support any storage.

-Wei Yan

-----Original Message-----
From: Qi Liang
Friday, July 15, 2005 1:37 PM
To: #Birt Development
Subject: API Change Request for IFileLocator


The attached is the API change request for IFileLocator. If no response
by the end of Jul. 19 (Shanghai Time), I will perform the check-in.


Qi Liang

Back to the top