Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [babel-dev] Babel Galileo Update Site

On 06/14/2009 02:35 PM, Kit Lo wrote:

I thought the Babel Galileo Update Site we produced already had the XSL
transformation done. Now I remember a conversation from Denis that we
had the transformation disabled because it was taking too long. Denis,
please confirm.

The way I remember it, p2 generation was disabled for taking too long. The XSL works on the p2 metadata, thus it was out too. I don't know of any performance problem with the XSL itself.

Yes, I ran the p2 publisher manually to produce the p2 repository. After
that, I ran the XSL transformation. I tested the p2 repository produced.
I installed the Babel language packs onto "eclipse-SDK-3.5RC4-win32.zip"
and "eclipse-jee-galileo-RC3-win32.zip". All the language packs
installed cleanly with no error messages in the .log file. Uninstalling
the language packs were also successful with no error messages.

I think I have produced a good p2 repository for the Babel Galileo
Update Site for the RC1 build. Everyone, please try this update site:
http://build.eclipse.org/technology/babel/test-updates/RC1/galileo/

Looks good so far for en_AU. Well, it didn't break my installation, which is nice. Not much Aussie English in sight, though: I think Babel Syncup is a little too eager to to use the flag "possibly incorrect".

A few more things to investigate or follow-up:
- My p2 publisher took about 15 hours to finish (for the Babel Galileo
RC1 build) even with bug 274025 fix, still not like the 40 seconds that
Sean mentioned in the bug report
- Sean, is the fix you have in bug 274025 just for the p2 metadata
generator, not the p2 publisher?

Correct, the fix is just for the generator. And the patch is unlikely to be merged upstream for a while, if ever, since it required an API change. An API change *will* happen (no way of fixing the problem without changing the API or at least its semantics), but it may take a different form, and it may never be in 3.5 by the sounds of it. So I don't think there's much point in my trying to fix the publisher.

We use a patched version of Eclipse/p2, or we do without the fix for the next month or three.

- According to this link, the metadata generator is deprecated, we
should use the publisher:
http://help.eclipse.org/stable/index.jsp?topic=/org.eclipse.platform.doc.isv/guide/p2_metadata_generator.html

The "generator deprecated" note wasn't at the top of http://wiki.eclipse.org/Equinox_p2_Metadata_Generator when I made the patch, nor, presumably, when we started generating p2 metadata.

I don't think we should abandon the metadata generator yet. It works for Babel, the performance patch works with it, and it should continue to exist for the life of Galileo. There's no hurry.


- for now, I will perform the manual process to produce the p2
repository for the Babel Galileo Update Site for the integration builds
until GA

Thank you.  It's nice to see a working update site again.

- I will talk to the team to see how to integrate the p2 publisher step
and XSL transformation step into the build process

Or we could apply the patch, re-enable metadata generation+xsl, and use the existing build process as of a few months ago.

We can afford to take our time on the publisher; maybe look at it when the performance bug is properly fixed (without needing a patch).

Thanks,
Kit Lo
IBM Eclipse SDK Globalization Technical Lead
Eclipse Babel Project Co-lead


*Sean Flanigan <sflaniga@xxxxxxxxxx>*
Sent by: babel-dev-bounces@xxxxxxxxxxx

06/12/2009 12:20 AM
Please respond to
Babel committers mailing list <babel-dev@xxxxxxxxxxx>


	
To
	Babel committers mailing list <babel-dev@xxxxxxxxxxx>
cc
	
Subject
	Re: [babel-dev] Babel Galileo Update Site


	





Hi Kit,

It sounds like you tried out the p2 publisher in this case, is that
right? (ie manually, not through Babel.) If so, you need to run the
XSL that Antoine mentioned. See the attachment to
https://bugs.eclipse.org/bugs/show_bug.cgi?id=256430.

If that still leads to dependency problems, we should reopen bug 256430,
since it sounds like the same problem.


Sean.


On 06/12/2009 04:32 AM, Kit Lo wrote:
 >
 > I spent some time in the past few days to understand the p2 publisher
 > problem. I noticed a few things.
 >
 > Ian agreed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=274025#c36
 > that there is still a problem with the p2 publisher. The p2 publisher
 > does not scale when there are many many features and plugins like our
 > case with the Babel language packs.
 >
 > However, my understanding of the p2 publisher is that it's just a tool
 > for converting a number of different resources (e.g. update site,
 > features and bundles, or product) into a p2 repository. If we have all
 > the time in the world, and the patience, the p2 publisher will
 > eventually finish (in about 20 hours). I tried connecting to the newly
 > generated p2 repository and update my Eclipse SDK 3.5 RC4 for Win32. The
 > update failed with the following message:
 >
 > !MESSAGE Missing requirement: org.eclipse.core.net.linux.x86 Pseudo
 > Translations NLS Support 3.5.0.v20090531043401
 > (org.eclipse.core.net.linux.x86.nl_en_AA 3.5.0.v20090531043401) requires
 > 'bundle org.eclipse.core.net.linux.x86 0.0.0' but it could not be found
 >
 > Our update site is including all the plugins we built using all the
 > translations we have in the database. That includes plugins like:
 >
 > org.eclipse.core.net.linux.x86.nl_<locale>
 > org.eclipse.core.net.win32.x86.nl_<locale>
 > org.eclipse.compare.tests.nl_<locale>
 > org.eclipse.pde.build.tests.nl_<locale>
 >
 > The problem is, if we are running Eclipse on Win32, the
 > *org.eclipse.core.net.linux.x86* plugin is not installed. If we are
 > running Eclipse on Linux, the *org.eclipse.core.net.win32.x86* plugin is
 > not installed. Also, the **.tests *plugins are only available from CVS
 > source repository but not included in the Eclipse downloadable binaries.
 >
 > Update Manager is just reading the update site info and p2 repository,
 > looking for the required Fragment-Host bundle, and it's true that it
 > could not be found.
 >
 > Therefore, I think the fundamental problem may be the way we build our
 > update site. I don't have much experience in building update site. I
 > wonder if there is an option to tell Update Manager to install a plugin
 > *"only if the Fragment-Host bundle is available"*. Otherwise, just skip
 > the updating the plugin.
 >
 > Kit Lo
 > IBM Eclipse SDK Globalization Technical Lead
 > Eclipse Babel Project Co-lead
 >
 >
 > ------------------------------------------------------------------------
 >
 > _______________________________________________
 > babel-dev mailing list
 > babel-dev@xxxxxxxxxxx
 > https://dev.eclipse.org/mailman/listinfo/babel-dev


--
Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat
_______________________________________________
babel-dev mailing list
babel-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/babel-dev


------------------------------------------------------------------------

_______________________________________________
babel-dev mailing list
babel-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/babel-dev


--
Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat


Back to the top