[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[aspectj-users] RE: [aspectj-dev] Should "declare dominates" be "declare preceden ce"?

There are no technical problems with changing dominates to precedence.  So far the only arguments have been in favor of this change.  Does anyone have a reason not to make the change?  If no dissenting opinions are heard in the next few days, then I'll make this change to the cvs tree in preparation for the next release.

-Jim

Details that should just go to aspectj-dev:

Neither dominates nor precedence is used as a keyword in the AspectJ grammar.  The AspectJ parser is fairly complicated due to its interactions with the eclipse Java parser.  However, the part used for parsing declare clauses and pointcut designators is fairly small and self-contained.  Anyone who's interested should look at the weaver module and find the class org.aspectj.weaver.patterns.PatternParser.  This is a fairly simple top-down recursive descent parser that we hope is easy for users to modify if they want to experiment with new declare or pointcut designator forms.


JP Fielding wrote:
>
> i don't see it as a major issue, but i do prefer 'precedence'.  i
> assumed they did this so as to not have to make a new keyword and toss
> and old one.
> 
> Lesiecki Nicholas wrote:
> 
> >I was thinking about "declare dominates" today. It seems to me that
> >"declare precedence" would be better terminology.
> >
> >Dominates made sense when there were two aspects involved:
> >
> >X dominates Y
> >
> >That reads like a sentence.
> >
> >When there is a comma delimited precedence order:
> >
> >declare dominates : X, Y, Z, *;
> >
> >it seems less intutive.
> >
> >I propose
> >
> >declare precedence : X, Y, Z, *;
> >
> >If implemented this change will mean a shorter cognitive leap between
> the
> >syntax (precedence) and what it governs (precedence). Since the form
> is
> >still not out of beta, I do not anticipate that the change will break
> many
> >programs. If it does, the fix will be as easy as "find and replace".
> >
> >What do people think?
> >
> >Cheers,
> >Nick
> >
> >__________________________________________________
> >Do you Yahoo!?
> >Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
> >http://mailplus.yahoo.com
> >_______________________________________________
> >aspectj-dev mailing list
> >aspectj-dev@xxxxxxxxxxx
> >http://dev.eclipse.org/mailman/listinfo/aspectj-dev
> >
> >
> >
> 
> 
> _______________________________________________
> aspectj-dev mailing list
> aspectj-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/aspectj-dev