Re: [ajdt-dev] Incremental builder shouldn't re-weave if no pointcutsch

[Andy Clement <andrew.clement@xxxxxxxxx>]

The incremental compiler is quite smart.  It does attempt exactly what you describe.  Within a basic project the only instance where I know it won't manage it is if you change around advice and don't have -XnoInline set - because the advice needs to be inlined in all advised places again.  If you can tell me more specifics (raise a bug if you like), we can go into it there.  And if you open the AJDT event trace view and turn on logging of all the interesting events in it, then save your change - it will give us more of an insight into why it is making the decisions it is making.  Oh, actually I imagine if you are not just using regular project dependencies, but instead are using aspectpath/inpath/etc, that will have an impact.

1.6.4 AspectJ was intended to be all about addressing these kinds of problem, so it is worth raising a bug if you want it looked at before this release goes out.

Andy.

2009/3/5 Neale Upstone <neale.upstone@xxxxxxxxxx>

Yes.  I'd thought of that one, which I assume is done by the AspectJ compiler, when it compiles the modified body.

With any luck, I'd expect the result to be hot-swappable in a debug session too.

Cheers,

Neale

> -----Original Message-----
> From: ajdt-dev-bounces@xxxxxxxxxxx
> [mailto:ajdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Eric Bodden
> Sent: 05 March 2009 12:54
> To: ajdt-dev@xxxxxxxxxxx
> Subject: Re: [ajdt-dev] Incremental builder shouldn't
> re-weave if no pointcutschanged...?
>
> Hi Neale.
>
> An advice could now be applying to your modified advice body, although
> previously it wasn't. so in general there is some weaving required. It
> may be possible to restrict it to the single aspect that you changed,
> though. But probably that's already happening.
>
> Eric
>
> 2009/3/5 Neale Upstone <neale.upstone@xxxxxxxxxx>:
> > Hi,
> >
> > Is there a document somewhere that says what triggers weaving on the
> > incremental builder?
> >
> > I just made a change to the body of some advice, without
> changing the
> > pointcut.  In my view this means that no weaving of my base
> project would be
> > necessary, as those would already be woven with all the
> correct joinpoints.
> >
> > Is the incremental compiler not (yet) smart enough to detect that no
> > pointcuts have changed, and to therefore only compile the aspects?
> > Cheers,
> >
> > Neale
> >
> >
> **********************************************************************
> > IMPORTANT NOTICE.
> > Confidentiality:  This e-mail and its attachments are
> intended for the above
> > named only and may be confidential.  If they have come to
> you in error you
> > must take no action based on them, nor must you copy or
> show them to anyone;
> > please reply to this e-mail and highlight the error.
> > Security Warning:  Please note that this e-mail has been
> created in the
> > knowledge that Internet e-mail is not a 100% secure
> communications medium.
> > We advise that you understand and observe this lack of security when
> > e-mailing us.
> > Viruses:  Although we have taken steps to ensure that this
> e-mail and
> > attachments are free from any virus, we advise that in
> keeping with good
> > computing practice the recipient should ensure they are
> actually virus free.
> > Monitoring and Scanning:  Cambridge Cognition has
> monitoring and scanning
> > systems in place in relation to emails sent and received
> to: monitor /
> > record business communications; prevent and detect crime;
> investigate the
> > use of the Company's internal and external email system; and provide
> > evidence of compliance with business practices.
> >
> > Cambridge Cognition Limited
> > Company Registration Number 4338746
> > Registered address:
> > Tunbridge Court
> > Tunbridge Lane
> > Bottisham
> > Cambridge
> > CB25 9TU
> > UK
> >
> **********************************************************************
> >
> >
> > _______________________________________________
> > ajdt-dev mailing list
> > ajdt-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/ajdt-dev
> >
> >
>
>
>
> --
> Eric Bodden
> Sable Research Group, McGill University
> Montréal, Québec, Canada
> _______________________________________________
> ajdt-dev mailing list
> ajdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ajdt-dev
>
**********************************************************************
IMPORTANT NOTICE.
Confidentiality:  This e-mail and its attachments are intended for the above named only and may be confidential.  If they have come to you in error you must take no action based on them, nor must you copy or show them to anyone; please reply to this e-mail and highlight the error.
Security Warning:  Please note that this e-mail has been created in the knowledge that Internet e-mail is not a 100% secure communications medium.
We advise that you understand and observe this lack of security when e-mailing us.
Viruses:  Although we have taken steps to ensure that this e-mail and attachments are free from any virus, we advise that in keeping with good computing practice the recipient should ensure they are actually virus free.
Monitoring and Scanning:  Cambridge Cognition has monitoring and scanning systems in place in relation to emails sent and received to: monitor / record business communications; prevent and detect crime; investigate the use of the Company's internal and external email system; and provide evidence of compliance with business practices.

Cambridge Cognition Limited
Company Registration Number 4338746
Registered address:
Tunbridge Court
Tunbridge Lane
Bottisham
Cambridge
CB25 9TU
UK
**********************************************************************

_______________________________________________
ajdt-dev mailing list
ajdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ajdt-dev