Eclipse Community Forums: Eclipse 4 » ModelAssembler fragment merge ordering failing?

Help

Home

Home » Eclipse Projects » Eclipse 4 » ModelAssembler fragment merge ordering failing?

Show: Today's Messages :: Show Polls :: Message Navigator

ModelAssembler fragment merge ordering failing? [message #1407787]

Wed, 13 August 2014 12:55

Chris Lingwood

Messages: 5
Registered: August 2014

Junior Member

I have a project where I've been contributing to popup menus using fragments. This has been good. I think my issues started when I upgraded to the release 4.4 but I'm not sure.

The fragment is:
<fragments xsi:type="fragment:StringModelFragment" xmi:id="_xQBUYFeLEeKQfrdYLJUp0w" featurename="children" parentElementId="xxx.popupmenu.xxx" positionInList="">

The problem manifests with this message:

!ENTRY org.eclipse.e4.ui.workbench 1 0 2014-08-13 13:01:29.870
!MESSAGE Nothing to merge for "platform:/plugin/xxx.xxx/fragment.e4xmi"

which is "caused" by this:

org.eclipse.e4.ui.model.fragment.impl.StringModelFragmentImpl
Line 284 ApplicationElement o = ModelUtils.findElementById(application, getParentElementId());

which is returning null for the id above (which does exist at runtime with the live model viewer).

The popup menus are all in shared elements. So i look in "application" while debugging and instead of finding them all, I find one, which is the wrong one. I can only assume the bit of code which is supposed to order the fragment merges doesn't quite do it right for this particular case and doesn't merge the one it needs first.

I've checked that the plugin that contributes the view with the popup menu is a dependency of the one trying to contribute to it. Oddly it only appears to happen on popup menus.

In short contributing to popupmenus in sharedElements defeats the merge ordering process (or at least appears to).

Any ideas? Can I force the order in any way? There is a post somewhere that suggests the dependency tree should do that for me.

Report message to a moderator

Re: ModelAssembler fragment merge ordering failing? [message #1407810 is a reply to message #1407787]

Wed, 13 August 2014 13:53

Thomas Schindl

Messages: 6651
Registered: July 2009

Senior Member

There was a regression introduced in 4.4 with fragment ordering see
https://bugs.eclipse.org/bugs/show_bug.cgi?id=438736

Tom

On 13.08.14 15:25, Chris Lingwood wrote:
> I have a project where I've been contributing to popup menus using
> fragments. This has been good. I think my issues started when I upgraded
> to the release 4.4 but I'm not sure.
> The fragment is:
> <fragments xsi:type="fragment:StringModelFragment"
> xmi:id="_xQBUYFeLEeKQfrdYLJUp0w" featurename="children"
> parentElementId="xxx.popupmenu.xxx" positionInList="">
>
> The problem manifests with this message:
>
> !ENTRY org.eclipse.e4.ui.workbench 1 0 2014-08-13 13:01:29.870
> !MESSAGE Nothing to merge for "platform:/plugin/xxx.xxx/fragment.e4xmi"
>
> which is "caused" by this:
>
> org.eclipse.e4.ui.model.fragment.impl.StringModelFragmentImpl
> Line 284 ApplicationElement o = ModelUtils.findElementById(application,
> getParentElementId());
>
> which is returning null for the id above (which does exist at runtime
> with the live model viewer).
>
> The popup menus are all in shared elements. So i look in "application"
> while debugging and instead of finding them all, I find one, which is
> the wrong one. I can only assume the bit of code which is supposed to
> order the fragment merges doesn't quite do it right for this particular
> case and doesn't merge the one it needs first.
> I've checked that the plugin that contributes the view with the popup
> menu is a dependency of the one trying to contribute to it. Oddly it
> only appears to happen on popup menus.
>
> In short contributing to popupmenus in sharedElements defeats the merge
> ordering process (or at least appears to).
>
> Any ideas? Can I force the order in any way? There is a post somewhere
> that suggests the dependency tree should do that for me.

Report message to a moderator