Eclipse Community Forums: EMF "Technology" (Ecore Tools, EMFatic, etc) » [Ecore Tools] Inconsistencies building from CVS

Help

Home

Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc) » [Ecore Tools] Inconsistencies building from CVS

Show: Today's Messages :: Show Polls :: Message Navigator

[Ecore Tools] Inconsistencies building from CVS [message #103191]

Tue, 20 November 2007 10:10

Eclipse User

Hi

I'm trying to shift my usage of the GMF Ecore Diagram to the Ecore Tools variant.

Perhaps I'm just too quick off the mark.

I was using Eclipse 3.3.1 and hit problems with WrapLabel/WrappingLabel and so
upgraded to 3.4M3, which fixes the compilation problems but when I
regenerate I find that WrapLabel is used rather than WrappingLabel and that there
are minor differences in the generated files. For instance the wizard category
in plugin.xml changes from org.eclipse.ui.Examples to org.eclipse.emf.ecoretools.diagram.

Is there a preferred mechanism/plug-in versions for dashboard building at present?

Could you please include your Java formatter preferences in CVS so that
regenerated code can match CVS. The dashboard.prefs is also missing from CVS.

Regards

Ed Willink

Report message to a moderator

Re: [Ecore Tools] Inconsistencies building from CVS [message #103237 is a reply to message #103191]

Tue, 20 November 2007 14:41

Eclipse User

Hi Ed,

Yes, you are probably a little too impatient, but this is very promising
for us : this means that people do not hesitate to try it before its
first release ! :-)

Anyway, as you noticed, CVS source code requires GMF 3.4M3 and its new
WrappingLabel implementation. However, as codegen templates have not
been fully updated, if you try to regenerate, you will get some old
references. I expect it will be soon fixed in the templates.

Then, there are probably some customized code, that we have not reported
at the gmfgen level : we will update this soon.

The Java formatter we are using is the GMF one
( http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.gmf/rel eng/org.eclipse.gmf.releng/eclipseSettings/GMF%20Formatter%2 0profile.xml?root=Modeling_Project&content-type=text%2Fx ml&revision=HEAD).
Otherwise, we have not used the Dashboard view to generate the editor.
But I can change this and include it in the CVS if you really need it.

Regards,
Jacques

Ed Willink a écrit :
> Hi
>
> I'm trying to shift my usage of the GMF Ecore Diagram to the Ecore Tools
> variant.
>
> Perhaps I'm just too quick off the mark.
>
> I was using Eclipse 3.3.1 and hit problems with WrapLabel/WrappingLabel
> and so
> upgraded to 3.4M3, which fixes the compilation problems but when I
> regenerate I find that WrapLabel is used rather than WrappingLabel and
> that there
> are minor differences in the generated files. For instance the wizard
> category
> in plugin.xml changes from org.eclipse.ui.Examples to
> org.eclipse.emf.ecoretools.diagram.
>
> Is there a preferred mechanism/plug-in versions for dashboard building
> at present?
>
> Could you please include your Java formatter preferences in CVS so that
> regenerated code can match CVS. The dashboard.prefs is also missing from
> CVS.
>
> Regards
>
> Ed Willink
>
>
>

Report message to a moderator

Re: [Ecore Tools] Inconsistencies building from CVS [message #103316 is a reply to message #103237]

Tue, 20 November 2007 18:54

Eclipse User

This is a multi-part message in MIME format.
--------------010803050302030501060808
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jacques

> Anyway, as you noticed, CVS source code requires GMF 3.4M3 and its new
> WrappingLabel implementation. However, as codegen templates have not
> been fully updated, if you try to regenerate, you will get some old
> references. I expect it will be soon fixed in the templates.

I presume you had to do a manual replace of all WrapLabel to WrappingLabel
since TextAware.xpt still (CVS one hour ago) uses

protected String getLabelTextHelper(org.eclipse.draw2d.IFigure figure) {
if (figure instanceof org.eclipse.gmf.runtime.draw2d.ui.figures.WrapLabel) {
return ((org.eclipse.gmf.runtime.draw2d.ui.figures.WrapLabel) figure).getText();
} else {
return ((org.eclipse.draw2d.Label) figure).getText();
}
}

to distinguish figure types. This fails horribly for WrappingLabel which
is not a WrapLabel and cannot be cast to Label. Attempting to open a generated
..ecorediag fails with a CCE.

>
> The Java formatter we are using is the GMF one
> ( http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.gmf/rel eng/org.eclipse.gmf.releng/eclipseSettings/GMF%20Formatter%2 0profile.xml?root=Modeling_Project&content-type=text%2Fx ml&revision=HEAD).

Ta. That is close to what I deduced. But I seem to need to manually reformat to
match line breaks in comments.

> Otherwise, we have not used the Dashboard view to generate the editor.
> But I can change this and include it in the CVS if you really need it.

I think you just need to include the attached. At present I know no other
way to activate gmfgen.

Ed

--------------010803050302030501060808
Content-Type: text/plain;
name="org.eclipse.gmf.bridge.ui.dashboard.prefs"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="org.eclipse.gmf.bridge.ui.dashboard.prefs"

#Tue Nov 20 09:07:02 GMT 2007
eclipse.preferences.version=1
gmf_dashboard/domainGenerationModel=platform\:/resource/org. eclipse.emf.ecore/model/Ecore.genmodel
gmf_dashboard/domainModel=platform\:/resource/org.eclipse.em f.ecore/model/Ecore.ecore
gmf_dashboard/generationModel=platform\:/resource/org.eclips e.emf.ecoretools.diagram/models/ecore.gmfgen
gmf_dashboard/graphicalDefinitionModel=platform\:/resource/o rg.eclipse.emf.ecoretools.diagram/models/ecore.gmfgraph
gmf_dashboard/mappingModel=platform\:/resource/org.eclipse.e mf.ecoretools.diagram/models/ecore.gmfmap
gmf_dashboard/toolingDefinitionModel=platform\:/resource/org .eclipse.emf.ecoretools.diagram/models/ecore.gmftool

--------------010803050302030501060808--

Report message to a moderator

Re: [Ecore Tools] Inconsistencies building from CVS [message #103456 is a reply to message #103316]

Wed, 21 November 2007 16:06

Eclipse User

Hi,

see my comments below,

Ed Willink a écrit :
> Hi Jacques
>
>> Anyway, as you noticed, CVS source code requires GMF 3.4M3 and its new
>> WrappingLabel implementation. However, as codegen templates have not
>> been fully updated, if you try to regenerate, you will get some old
>> references. I expect it will be soon fixed in the templates.
>
> I presume you had to do a manual replace of all WrapLabel to WrappingLabel
> since TextAware.xpt still (CVS one hour ago) uses
>
> protected String getLabelTextHelper(org.eclipse.draw2d.IFigure
> figure) {
> if (figure instanceof
> org.eclipse.gmf.runtime.draw2d.ui.figures.WrapLabel) {
> return
> ((org.eclipse.gmf.runtime.draw2d.ui.figures.WrapLabel) figure).getText();
> } else {
> return ((org.eclipse.draw2d.Label) figure).getText();
> }
> }
>
> to distinguish figure types. This fails horribly for WrappingLabel which
> is not a WrapLabel and cannot be cast to Label. Attempting to open a
> generated
> .ecorediag fails with a CCE.
In fact, I checked out the GMF source code from CVS, and using
refactoring capabilities on the renaming of a class, it updated all my
old references : this is really better than replacing all the deprecated
references in all my projects using GMF. Refactoring is really powerful!
>
>>
>> The Java formatter we are using is the GMF one
>> ( http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.gmf/rel eng/org.eclipse.gmf.releng/eclipseSettings/GMF%20Formatter%2 0profile.xml?root=Modeling_Project&content-type=text%2Fx ml&revision=HEAD).
>
>
> Ta. That is close to what I deduced. But I seem to need to manually
> reformat to
> match line breaks in comments.
In fact, after each generation, I manually perform a global "Reformat"
on the whole project : however I noticed, that I behaves strangely on
inlined comments while applying several "Reformat" action. If I have
time, I will try to figure out what is happening and open a bug if
necessary.
>
>> Otherwise, we have not used the Dashboard view to generate the editor.
>> But I can change this and include it in the CVS if you really need it.
>
> I think you just need to include the attached. At present I know no other
> way to activate gmfgen.
I have just committed it on the CVS.

Jacques
>
> Ed
>

Report message to a moderator