Eclipse Community Forums: Graphiti » Patterns - DeleteFeature hasDone problem

Help

Home

Home » Modeling » Graphiti » Patterns - DeleteFeature hasDone problem

Show: Today's Messages :: Show Polls :: Message Navigator

Patterns - DeleteFeature hasDone problem [message #719913]

Mon, 29 August 2011 12:45

Volker Wegert

Messages: 182
Registered: July 2009

Senior Member

Hello,

I've got a problem with the deletion of diagram elements using patterns. I'm using Graphiti 0.9.0.v20110818-1338.

The pattern implementations use the class DeleteFeatureForPattern that extends DefaultDeleteFeature and therefore contain its own property doneChanges. Following the attribute chain delegate --> pattern --> wrappedDeleteFeature, there's a different instance of DefaultDeleteFeature that handles the actual object deletion and sets its own attribute doneChanges to true. The command stack performs a check to see whether any changes were made, and as far as I can see, it only checks the "outer" DeleteFeatureForPattern instance. The doneChanges attribute of this class is never set to true, so the entire undo stack is reverted. I'll attach a screenshot to illustrate the problem.

index.php/fa/3798/0/

I'm not entirely sure, but I think I've found a bug - could anyone confirm this?

Thanks
Volker

Attachment: Graphiti-Delete-Problem.png
(Size: 126.75KB, Downloaded 446 times)

Report message to a moderator

Re: Patterns - DeleteFeature hasDone problem [message #719937 is a reply to message #719913]

Mon, 29 August 2011 14:13

Michael Wenz

Messages: 1931
Registered: July 2009
Location: Walldorf, Germany

Senior Member

Yes you're right. This is a bug. Would you please open a Bugzilla for this?

Thanks,
Michael

"Volker Wegert" schrieb im Newsbeitrag
news:j3g0vm$q71$1@news.eclipse.org...

Hello,

I've got a problem with the deletion of diagram elements using patterns. I'm
using Graphiti 0.9.0.v20110818-1338.

The pattern implementations use the class DeleteFeatureForPattern that
extends DefaultDeleteFeature and therefore contain its own property
doneChanges. Following the attribute chain delegate --> pattern -->
wrappedDeleteFeature, there's a different instance of DefaultDeleteFeature
that handles the actual object deletion and sets its own attribute
doneChanges to true. The command stack performs a check to see whether any
changes were made, and as far as I can see, it only checks the "outer"
DeleteFeatureForPattern instance. The doneChanges attribute of this class is
never set to true, so the entire undo stack is reverted. I'll attach a
screenshot to illustrate the problem.

I'm not entirely sure, but I think I've found a bug - could anyone confirm
this?

Thanks
Volker

Report message to a moderator