| Modifying soruce code Vs. Using the extension point [message #75734] |
Wed, 26 November 2008 21:13  |
Eclipse User |
|
|
|
Hi
My Goal:
Develop a plugin for Eclipse, this plugin has a dependeny on "plugin
X"
My Problem:
Some of features is not provided in the extension points of "plugin
X"
I'm curious:
I can achieve some of my targets via modifying the source code of
"plugin X" and re-publish "plugin X"
I know it's not a good practice
But what're the disadvantages of modifying source code directly?
Thanks
Xing Yun
|
|
|
|
| Re: Modifying soruce code Vs. Using the extension point [message #75767 is a reply to message #75750] |
Thu, 27 November 2008 00:01  |
| Eclipse User |
|
|
|
Thaks a lot for the quick reply
:)
Regards
Xing Yun
"Wayne Beaton" <wayne@eclipse.org> wrote in message
news:ggl4aj$v8s$1@build.eclipse.org...
> For one, if you modify the code, then you have to distribute it with your
> code. You run the risk that your changes might not be compatible with
> other plug-in providers. Further, as changes are made to the original
> code, you will have to maintain yours.
>
> If you think something needs to be changed, you could consider filing a
> bug report to ask for it to be changed/added (you can contribute code for
> the change).
>
> Be sure to abide by the EPL if you do decide to change code.
>
> Wayne
>
> xing yun wrote:
>> Hi
>> My Goal:
>> Develop a plugin for Eclipse, this plugin has a dependeny on
>> "plugin X"
>>
>> My Problem:
>> Some of features is not provided in the extension points of
>> "plugin X"
>>
>> I'm curious:
>> I can achieve some of my targets via modifying the source code of
>> "plugin X" and re-publish "plugin X"
>> I know it's not a good practice
>>
>> But what're the disadvantages of modifying source code directly?
>>
>> Thanks
>>
>> Xing Yun
|
|
|
| Re: Modifying soruce code Vs. Using the extension point [message #601881 is a reply to message #75734] |
Wed, 26 November 2008 22:30 |
| Eclipse User |
|
|
|
For one, if you modify the code, then you have to distribute it with
your code. You run the risk that your changes might not be compatible
with other plug-in providers. Further, as changes are made to the
original code, you will have to maintain yours.
If you think something needs to be changed, you could consider filing a
bug report to ask for it to be changed/added (you can contribute code
for the change).
Be sure to abide by the EPL if you do decide to change code.
Wayne
xing yun wrote:
> Hi
> My Goal:
> Develop a plugin for Eclipse, this plugin has a dependeny on "plugin
> X"
>
> My Problem:
> Some of features is not provided in the extension points of "plugin
> X"
>
> I'm curious:
> I can achieve some of my targets via modifying the source code of
> "plugin X" and re-publish "plugin X"
> I know it's not a good practice
>
> But what're the disadvantages of modifying source code directly?
>
> Thanks
>
> Xing Yun
>
>
|
|
|
| Re: Modifying soruce code Vs. Using the extension point [message #601886 is a reply to message #75750] |
Thu, 27 November 2008 00:01 |
| Eclipse User |
|
|
|
Thaks a lot for the quick reply
:)
Regards
Xing Yun
"Wayne Beaton" <wayne@eclipse.org> wrote in message
news:ggl4aj$v8s$1@build.eclipse.org...
> For one, if you modify the code, then you have to distribute it with your
> code. You run the risk that your changes might not be compatible with
> other plug-in providers. Further, as changes are made to the original
> code, you will have to maintain yours.
>
> If you think something needs to be changed, you could consider filing a
> bug report to ask for it to be changed/added (you can contribute code for
> the change).
>
> Be sure to abide by the EPL if you do decide to change code.
>
> Wayne
>
> xing yun wrote:
>> Hi
>> My Goal:
>> Develop a plugin for Eclipse, this plugin has a dependeny on
>> "plugin X"
>>
>> My Problem:
>> Some of features is not provided in the extension points of
>> "plugin X"
>>
>> I'm curious:
>> I can achieve some of my targets via modifying the source code of
>> "plugin X" and re-publish "plugin X"
>> I know it's not a good practice
>>
>> But what're the disadvantages of modifying source code directly?
>>
>> Thanks
>>
>> Xing Yun
|
|
|
Powered by
FUDForum. Page generated in 0.03791 seconds
Home