Eclipse Community Forums: AspectJ » is ajdt support all common jdt refactorings?

Help

Home

Home » Language IDEs » AspectJ » is ajdt support all common jdt refactorings?

Show: Today's Messages :: Show Polls :: Message Navigator

is ajdt support all common jdt refactorings? [message #57492]

Mon, 17 October 2005 04:04

Eugene Kuleshov

Messages: 504
Registered: July 2009

Senior Member

Hi,

I'm using Eclipse 3.2M1 and latest AJDT 1.3.0 build available from
the update site.
I've tried to use some basic refactoring such as inline method from
within advice code (before or around) and got an error "compilation unit
must end with .java". Is it a bug or I am doing something wrong here?

Thanks

Eugene

PS: here is the stack trace

java.lang.reflect.InvocationTargetException
at org.eclipse.jface.operation.ModalContext.run(ModalContext.ja va:327)
at
org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDia log2.run(RefactoringWizardDialog2.java:293)
at
org.eclipse.ltk.ui.refactoring.RefactoringWizard.internalPer formFinish(RefactoringWizard.java:547)
at
org.eclipse.ltk.ui.refactoring.UserInputWizardPage.performFi nish(UserInputWizardPage.java:153)
at
org.eclipse.ltk.ui.refactoring.RefactoringWizard.performFini sh(RefactoringWizard.java:613)
at
org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDia log2.okPressed(RefactoringWizardDialog2.java:417)
at org.eclipse.jface.dialogs.Dialog.buttonPressed(Dialog.java:4 09)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.jav a:556)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListe ner.java:90)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java :66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:868)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.ja va:3137)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java :2765)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:809 )
at org.eclipse.jface.window.Window.open(Window.java:787)
at
org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperatio n$1.run(RefactoringWizardOpenOperation.java:125)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator .java:69)
at
org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperatio n.run(RefactoringWizardOpenOperation.java:138)
at
org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringS tarter.activate(RefactoringStarter.java:40)
at
org.eclipse.jdt.internal.corext.refactoring.RefactoringExecu tionStarter.startInlineMethodRefactoring(RefactoringExecutio nStarter.java:255)
at
org.eclipse.jdt.internal.ui.refactoring.actions.InlineMethod Action.run(InlineMethodAction.java:133)
at
org.eclipse.jdt.internal.ui.refactoring.actions.InlineMethod Action.run(InlineMethodAction.java:126)
at
org.eclipse.jdt.internal.ui.refactoring.actions.InlineMethod Action.tryInlineMethod(InlineMethodAction.java:142)
at org.eclipse.jdt.ui.actions.InlineAction.run(InlineAction.jav a:114)
at
org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchR un(SelectionDispatchAction.java:226)
at
org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(Selec tionDispatchAction.java:198)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:996 )
at org.eclipse.ui.commands.ActionHandler.execute(ActionHandler. java:182)
at
org.eclipse.ui.internal.handlers.LegacyHandlerWrapper.execut e(LegacyHandlerWrapper.java:108)
at org.eclipse.core.commands.Command.execute(Command.java:311)
at
org.eclipse.core.commands.ParameterizedCommand.execute(Param eterizedCommand.java:396)
at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeComman d(WorkbenchKeyboard.java:459)
at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(Workben chKeyboard.java:781)
at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEve nt(WorkbenchKeyboard.java:828)
at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequ enceBindings(WorkbenchKeyboard.java:550)
at
org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(Work benchKeyboard.java:493)
at
org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter .handleEvent(WorkbenchKeyboard.java:117)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java :66)
at org.eclipse.swt.widgets.Display.filterEvent(Display.java:920 )
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:867)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:892)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:877)
at org.eclipse.swt.widgets.Control.traverse(Control.java:2794)
at org.eclipse.swt.widgets.Control.translateMnemonic(Control.ja va:2635)
at org.eclipse.swt.widgets.Composite.translateMnemonic(Composit e.java:854)
at org.eclipse.swt.widgets.Control.translateMnemonic(Control.ja va:2653)
at org.eclipse.swt.widgets.Display.translateMnemonic(Display.ja va:3571)
at org.eclipse.swt.widgets.Display.filterMessage(Display.java:9 34)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java :2761)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.jav a:1734)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1698)
at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Work bench.java:367)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.j ava:143)
at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplicatio n.java:103)
at
org.eclipse.core.internal.runtime.PlatformActivator$1.run(Pl atformActivator.java:226)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseS tarter.java:376)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseS tarter.java:163)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce ssorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe thodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.core.launcher.Main.invokeFramework(Main.java:338 )
at org.eclipse.core.launcher.Main.basicRun(Main.java:282)
at org.eclipse.core.launcher.Main.run(Main.java:977)
at org.eclipse.core.launcher.Main.main(Main.java:952)
Caused by: java.lang.IllegalArgumentException: Compilation unit name
must end with .java
at
org.eclipse.jdt.internal.core.PackageFragment.getCompilation Unit(PackageFragment.java:192)
at
org.eclipse.jdt.core.dom.TypeBinding.getCompilationUnit(Type Binding.java:128)
at
org.eclipse.jdt.core.dom.TypeBinding.getUnresolvedJavaElemen t(TypeBinding.java:438)
at
org.eclipse.jdt.core.dom.TypeBinding.getUnresolvedJavaElemen t(TypeBinding.java:377)
at org.eclipse.jdt.core.dom.TypeBinding.getJavaElement(TypeBind ing.java:370)
at
org.eclipse.jdt.core.dom.MethodBinding.getUnresolvedJavaElem ent(MethodBinding.java:168)
at
org.eclipse.jdt.core.dom.MethodBinding.getJavaElement(Method Binding.java:161)
at
org.eclipse.jdt.internal.corext.refactoring.code.TargetProvi der$MemberTypeTargetProvider.getAffectedCompilationUnits(Tar getProvider.java:366)
at
org.eclipse.jdt.internal.corext.refactoring.code.InlineMetho dRefactoring.checkFinalConditions(InlineMethodRefactoring.ja va:199)
at
org.eclipse.ltk.core.refactoring.CheckConditionsOperation.ru n(CheckConditionsOperation.java:84)
at
org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(C reateChangeOperation.java:114)
at
org.eclipse.ltk.core.refactoring.PerformChangeOperation.run( PerformChangeOperation.java:189)
at org.eclipse.core.internal.resources.Workspace.run(Workspace. java:1719)
at
org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAda pter.run(WorkbenchRunnableAdapter.java:86)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread. run(ModalContext.java:113)
Root exception:
java.lang.IllegalArgumentException: Compilation unit name must end with
..java
at
org.eclipse.jdt.internal.core.PackageFragment.getCompilation Unit(PackageFragment.java:192)
at
org.eclipse.jdt.core.dom.TypeBinding.getCompilationUnit(Type Binding.java:128)
at
org.eclipse.jdt.core.dom.TypeBinding.getUnresolvedJavaElemen t(TypeBinding.java:438)
at
org.eclipse.jdt.core.dom.TypeBinding.getUnresolvedJavaElemen t(TypeBinding.java:377)
at org.eclipse.jdt.core.dom.TypeBinding.getJavaElement(TypeBind ing.java:370)
at
org.eclipse.jdt.core.dom.MethodBinding.getUnresolvedJavaElem ent(MethodBinding.java:168)
at
org.eclipse.jdt.core.dom.MethodBinding.getJavaElement(Method Binding.java:161)
at
org.eclipse.jdt.internal.corext.refactoring.code.TargetProvi der$MemberTypeTargetProvider.getAffectedCompilationUnits(Tar getProvider.java:366)
at
org.eclipse.jdt.internal.corext.refactoring.code.InlineMetho dRefactoring.checkFinalConditions(InlineMethodRefactoring.ja va:199)
at
org.eclipse.ltk.core.refactoring.CheckConditionsOperation.ru n(CheckConditionsOperation.java:84)
at
org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(C reateChangeOperation.java:114)
at
org.eclipse.ltk.core.refactoring.PerformChangeOperation.run( PerformChangeOperation.java:189)
at org.eclipse.core.internal.resources.Workspace.run(Workspace. java:1719)
at
org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAda pter.run(WorkbenchRunnableAdapter.java:86)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread. run(ModalContext.java:113)

Report message to a moderator

Re: is ajdt support all common jdt refactorings? [message #57544 is a reply to message #57492]

Mon, 17 October 2005 10:19

Sian January

Messages: 83
Registered: July 2009

Member

Hi Eugene,

Yes this is a bug. AJDT has some support for editor functions such as
organise imports and code completion but no refactoring support at the
moment. If you want to raise a bug on bugzilla
(https://bugs.eclipse.org/bugs/enter_bug.cgi?product=AJDT) a general
refactoring bug would probably be the most useful.

Thanks,

Sian

Eugene Kuleshov wrote:
> Hi,
>
> I'm using Eclipse 3.2M1 and latest AJDT 1.3.0 build available from the
> update site.
> I've tried to use some basic refactoring such as inline method from
> within advice code (before or around) and got an error "compilation unit
> must end with .java". Is it a bug or I am doing something wrong here?
>
> Thanks
>
> Eugene
>
> PS: here is the stack trace
>
> java.lang.reflect.InvocationTargetException
> at org.eclipse.jface.operation.ModalContext.run(ModalContext.ja va:327)
> at
> org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDia log2.run(RefactoringWizardDialog2.java:293)
>
> at
> org.eclipse.ltk.ui.refactoring.RefactoringWizard.internalPer formFinish(RefactoringWizard.java:547)
>
> at
> org.eclipse.ltk.ui.refactoring.UserInputWizardPage.performFi nish(UserInputWizardPage.java:153)
>
> at
> org.eclipse.ltk.ui.refactoring.RefactoringWizard.performFini sh(RefactoringWizard.java:613)
>
> at
> org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDia log2.okPressed(RefactoringWizardDialog2.java:417)
>
> at org.eclipse.jface.dialogs.Dialog.buttonPressed(Dialog.java:4 09)
> at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.jav a:556)
> at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListe ner.java:90)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java :66)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:868)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.ja va:3137)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java :2765)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:809 )
> at org.eclipse.jface.window.Window.open(Window.java:787)
> at
> org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperatio n$1.run(RefactoringWizardOpenOperation.java:125)
>
> at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator .java:69)
> at
> org.eclipse.ltk.ui.refactoring.RefactoringWizardOpenOperatio n.run(RefactoringWizardOpenOperation.java:138)
>
> at
> org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringS tarter.activate(RefactoringStarter.java:40)
>
> at
> org.eclipse.jdt.internal.corext.refactoring.RefactoringExecu tionStarter.startInlineMethodRefactoring(RefactoringExecutio nStarter.java:255)
>
> at
> org.eclipse.jdt.internal.ui.refactoring.actions.InlineMethod Action.run(InlineMethodAction.java:133)
>
> at
> org.eclipse.jdt.internal.ui.refactoring.actions.InlineMethod Action.run(InlineMethodAction.java:126)
>
> at
> org.eclipse.jdt.internal.ui.refactoring.actions.InlineMethod Action.tryInlineMethod(InlineMethodAction.java:142)
>
> at org.eclipse.jdt.ui.actions.InlineAction.run(InlineAction.jav a:114)
> at
> org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchR un(SelectionDispatchAction.java:226)
>
> at
> org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(Selec tionDispatchAction.java:198)
>
> at org.eclipse.jface.action.Action.runWithEvent(Action.java:996 )
> at org.eclipse.ui.commands.ActionHandler.execute(ActionHandler. java:182)
> at
> org.eclipse.ui.internal.handlers.LegacyHandlerWrapper.execut e(LegacyHandlerWrapper.java:108)
>
> at org.eclipse.core.commands.Command.execute(Command.java:311)
> at
> org.eclipse.core.commands.ParameterizedCommand.execute(Param eterizedCommand.java:396)
>
> at
> org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeComman d(WorkbenchKeyboard.java:459)
>
> at
> org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(Workben chKeyboard.java:781)
>
> at
> org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEve nt(WorkbenchKeyboard.java:828)
>
> at
> org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequ enceBindings(WorkbenchKeyboard.java:550)
>
> at
> org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(Work benchKeyboard.java:493)
>
> at
> org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter .handleEvent(WorkbenchKeyboard.java:117)
>
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java :66)
> at org.eclipse.swt.widgets.Display.filterEvent(Display.java:920 )
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:867)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:892)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:877)
> at org.eclipse.swt.widgets.Control.traverse(Control.java:2794)
> at org.eclipse.swt.widgets.Control.translateMnemonic(Control.ja va:2635)
> at org.eclipse.swt.widgets.Composite.translateMnemonic(Composit e.java:854)
> at org.eclipse.swt.widgets.Control.translateMnemonic(Control.ja va:2653)
> at org.eclipse.swt.widgets.Display.translateMnemonic(Display.ja va:3571)
> at org.eclipse.swt.widgets.Display.filterMessage(Display.java:9 34)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java :2761)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.jav a:1734)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1698)
> at
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Work bench.java:367)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.j ava:143)
> at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplicatio n.java:103)
> at
> org.eclipse.core.internal.runtime.PlatformActivator$1.run(Pl atformActivator.java:226)
>
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseS tarter.java:376)
>
> at
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseS tarter.java:163)
>
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce ssorImpl.java:39)
>
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe thodAccessorImpl.java:25)
>
> at java.lang.reflect.Method.invoke(Method.java:585)
> at org.eclipse.core.launcher.Main.invokeFramework(Main.java:338 )
> at org.eclipse.core.launcher.Main.basicRun(Main.java:282)
> at org.eclipse.core.launcher.Main.run(Main.java:977)
> at org.eclipse.core.launcher.Main.main(Main.java:952)
> Caused by: java.lang.IllegalArgumentException: Compilation unit name
> must end with .java
> at
> org.eclipse.jdt.internal.core.PackageFragment.getCompilation Unit(PackageFragment.java:192)
>
> at
> org.eclipse.jdt.core.dom.TypeBinding.getCompilationUnit(Type Binding.java:128)
>
> at
> org.eclipse.jdt.core.dom.TypeBinding.getUnresolvedJavaElemen t(TypeBinding.java:438)
>
> at
> org.eclipse.jdt.core.dom.TypeBinding.getUnresolvedJavaElemen t(TypeBinding.java:377)
>
> at
> org.eclipse.jdt.core.dom.TypeBinding.getJavaElement(TypeBind ing.java:370)
> at
> org.eclipse.jdt.core.dom.MethodBinding.getUnresolvedJavaElem ent(MethodBinding.java:168)
>
> at
> org.eclipse.jdt.core.dom.MethodBinding.getJavaElement(Method Binding.java:161)
>
> at
> org.eclipse.jdt.internal.corext.refactoring.code.TargetProvi der$MemberTypeTargetProvider.getAffectedCompilationUnits(Tar getProvider.java:366)
>
> at
> org.eclipse.jdt.internal.corext.refactoring.code.InlineMetho dRefactoring.checkFinalConditions(InlineMethodRefactoring.ja va:199)
>
> at
> org.eclipse.ltk.core.refactoring.CheckConditionsOperation.ru n(CheckConditionsOperation.java:84)
>
> at
> org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(C reateChangeOperation.java:114)
>
> at
> org.eclipse.ltk.core.refactoring.PerformChangeOperation.run( PerformChangeOperation.java:189)
>
> at org.eclipse.core.internal.resources.Workspace.run(Workspace. java:1719)
> at
> org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAda pter.run(WorkbenchRunnableAdapter.java:86)
>
> at
> org.eclipse.jface.operation.ModalContext$ModalContextThread. run(ModalContext.java:113)
>
> Root exception:
> java.lang.IllegalArgumentException: Compilation unit name must end with
> .java
> at
> org.eclipse.jdt.internal.core.PackageFragment.getCompilation Unit(PackageFragment.java:192)
>
> at
> org.eclipse.jdt.core.dom.TypeBinding.getCompilationUnit(Type Binding.java:128)
>
> at
> org.eclipse.jdt.core.dom.TypeBinding.getUnresolvedJavaElemen t(TypeBinding.java:438)
>
> at
> org.eclipse.jdt.core.dom.TypeBinding.getUnresolvedJavaElemen t(TypeBinding.java:377)
>
> at
> org.eclipse.jdt.core.dom.TypeBinding.getJavaElement(TypeBind ing.java:370)
> at
> org.eclipse.jdt.core.dom.MethodBinding.getUnresolvedJavaElem ent(MethodBinding.java:168)
>
> at
> org.eclipse.jdt.core.dom.MethodBinding.getJavaElement(Method Binding.java:161)
>
> at
> org.eclipse.jdt.internal.corext.refactoring.code.TargetProvi der$MemberTypeTargetProvider.getAffectedCompilationUnits(Tar getProvider.java:366)
>
> at
> org.eclipse.jdt.internal.corext.refactoring.code.InlineMetho dRefactoring.checkFinalConditions(InlineMethodRefactoring.ja va:199)
>
> at
> org.eclipse.ltk.core.refactoring.CheckConditionsOperation.ru n(CheckConditionsOperation.java:84)
>
> at
> org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(C reateChangeOperation.java:114)
>
> at
> org.eclipse.ltk.core.refactoring.PerformChangeOperation.run( PerformChangeOperation.java:189)
>
> at org.eclipse.core.internal.resources.Workspace.run(Workspace. java:1719)
> at
> org.eclipse.ltk.internal.ui.refactoring.WorkbenchRunnableAda pter.run(WorkbenchRunnableAdapter.java:86)
>
> at
> org.eclipse.jface.operation.ModalContext$ModalContextThread. run(ModalContext.java:113)
>

Report message to a moderator

Re: is ajdt support all common jdt refactorings? [message #57683 is a reply to message #57544]

Mon, 17 October 2005 15:31

Eugene Kuleshov

Messages: 504
Registered: July 2009

Senior Member

Thanks Sian. The strange thing is that extract method refactoring
does work.

Anyway, here is bugzilla issue for this.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=112806

regards,
Eugene

Sian January wrote:
> Hi Eugene,
>
> Yes this is a bug. AJDT has some support for editor functions such as
> organise imports and code completion but no refactoring support at the
> moment. If you want to raise a bug on bugzilla
> (https://bugs.eclipse.org/bugs/enter_bug.cgi?product=AJDT) a general
> refactoring bug would probably be the most useful.
>
> Thanks,
>
> Sian
>
>
>
> Eugene Kuleshov wrote:
>
>> Hi,
>>
>> I'm using Eclipse 3.2M1 and latest AJDT 1.3.0 build available from
>> the update site.
>> I've tried to use some basic refactoring such as inline method from
>> within advice code (before or around) and got an error "compilation
>> unit must end with .java". Is it a bug or I am doing something wrong
>> here?
>>
>> Thanks
>>
>> Eugene

Report message to a moderator